Allow _.bindAll to take arrays #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remind me the advantage of this over varargs-style passing? What's the real-world use case? (#1996 (comment)) |
|
I see the biggest win as parity with the other object functions |
| if (length <= 1) throw new Error('bindAll must be passed function names'); | ||
| for (i = 1; i < length; i++) { | ||
| key = arguments[i]; | ||
| var keys = flatten(arguments, false, false, 1); |
There was a problem hiding this comment.
With #2140
_.bindAll = _.restParams(function(obj, params) {
params = flatten(params);
|
Rebase for a clean merge? |
Closes jashkenas#1996, supercedes jashkenas#2005.
|
Rebased. |
jashkenas
added a commit
that referenced
this pull request
May 22, 2015
Allow _.bindAll to take arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1996, supercedes #2005.