Code

Functional style#2908

Code

Open

jgonggrijp wants to merge 79 commits intojashkenas:masterjashkenas/underscore:masterfrom jgonggrijp:functionaljgonggrijp/underscore:functionalCopy head branch name to clipboard

+1,248-1,180

Commits

Commits on Dec 30, 2020

• Simplify _.iteratee

  jgonggrijp

  committed
  c22e1e9

  Copy full SHA for c22e1e9

• Make _.contains generic over the collection type

  jgonggrijp

  committed
  ce15d38

  Copy full SHA for ce15d38

• Use _.find in _.each

  jgonggrijp

  committed
  f0e9bc3

  Copy full SHA for f0e9bc3

• Use _.find in _.every and _.some

  jgonggrijp

  committed
  0b51eae

  Copy full SHA for 0b51eae

• Use _.each in createReduce

  jgonggrijp

  committed
  f4e0f71

  Copy full SHA for f4e0f71

• Use _.chain in _chainResult

  jgonggrijp

  committed
  11bdeab

  Copy full SHA for 11bdeab

• Slim down use of _.each in _.filter

  jgonggrijp

  committed
  3bc4c50

  Copy full SHA for 3bc4c50

• Use _.each in _.map

  jgonggrijp

  committed
  ea55aeb

  Copy full SHA for ea55aeb

• Import modules/iteratee.js for its side effect in modules/_cb.js

  jgonggrijp

  committed
  5092fb5

  Copy full SHA for 5092fb5

• Use isArrayLike in _.isEmpty

  jgonggrijp

  committed
  008990f

  Copy full SHA for 008990f

• Remove an unnecessary check in _.omit

  jgonggrijp

  committed
  bd14ef1

  Copy full SHA for bd14ef1

• Remove an unnecessary check from _.pick

  jgonggrijp

  committed
  38129be

  Copy full SHA for 38129be

• Deduplicate subexpressions in _.sample

  jgonggrijp

  committed
  be5b8a2

  Copy full SHA for be5b8a2

Commits on Feb 4, 2021

• Reorder and document _.toArray

  jgonggrijp

  committed
  adfb2f8

  Copy full SHA for adfb2f8

• Simplify and deduplicate _.uniq

  jgonggrijp

  committed
  e842fd5

  Copy full SHA for e842fd5

• Use getLength in collectNonEnumProps

  jgonggrijp

  committed
  5d73fb3

  Copy full SHA for 5d73fb3

• Use getLength in _.bindAll

  jgonggrijp

  committed
  3753fe7

  Copy full SHA for 3753fe7

• Refactor _.first and _.last, using getLength

  Show description for d7393b4
  jgonggrijp

  committed
  d7393b4

  Copy full SHA for d7393b4

• Use getLength in _.invoke

  jgonggrijp

  committed
  18fd848

  Copy full SHA for 18fd848

• Remove switch pyramid of doom from _.restArguments

  jgonggrijp

  committed
  296be9e

  Copy full SHA for 296be9e

• Simplify _.restArguments using array.slice

  jgonggrijp

  committed
  60319af

  Copy full SHA for 60319af

• Use _.last in _.invoke

  jgonggrijp

  committed
  645eafe

  Copy full SHA for 645eafe

• Use _.initial in _.invoke

  jgonggrijp

  committed
  aac1042

  Copy full SHA for aac1042

• Simplify internal flatten using array.push

  jgonggrijp

  committed
  431b84e

  Copy full SHA for 431b84e

• Use array.push in _.partial

  jgonggrijp

  committed
  5781d89

  Copy full SHA for 5781d89

• Factor out linearSearch and binarySearch base algorithms

  jgonggrijp

  committed
  81a7a77

  Copy full SHA for 81a7a77

• Use linearSearch in _.has

  jgonggrijp

  committed
  b4ab797

  Copy full SHA for b4ab797

• Use linearSearch in _.intersection

  jgonggrijp

  committed
  5bc6d47

  Copy full SHA for 5bc6d47

• Use linearSearch in the internal flatten

  jgonggrijp

  committed
  eef39cd

  Copy full SHA for eef39cd

• Use linearSearch in _methodFingerprint

  jgonggrijp

  committed
  b63e425

  Copy full SHA for b63e425

• Polish use of linearSearch in _.intersection

  jgonggrijp

  committed
  2fac273

  Copy full SHA for 2fac273

• Use linearSearch in _.mapObject

  jgonggrijp

  committed
  9624b1b

  Copy full SHA for 9624b1b

• Use linearSearch in collectNonEnumProps

  jgonggrijp

  committed
  3120fd2

  Copy full SHA for 3120fd2

• Use linearSearch in internal flatten, again

  jgonggrijp

  committed
  3a326ad

  Copy full SHA for 3a326ad

• Use linearSearch in _.bindAll

  jgonggrijp

  committed
  1f3562a

  Copy full SHA for 1f3562a

• Use linearSearch in _.chunk

  jgonggrijp

  committed
  cba898c

  Copy full SHA for cba898c

• Use linearSearch in _.isEqual

  jgonggrijp

  committed
  230fee1

  Copy full SHA for 230fee1

• Replace _.each by linearSearch in _.mixin and the array methods

  Show description for a0ef35a
  jgonggrijp

  committed
  a0ef35a

  Copy full SHA for a0ef35a

• Use linearSearch in _.pick

  jgonggrijp

  committed
  8764f04

  Copy full SHA for 8764f04

• Use linearSearch in _.sample

  jgonggrijp

  committed
  bc0e942

  Copy full SHA for bc0e942

• Inline _.sortedIndex and _.sortedLastIndex

  jgonggrijp

  committed
  65c16db

  Copy full SHA for 65c16db

• Replace linearSearch by _.times in _.sample

  jgonggrijp

  committed
  8cfa13f

  Copy full SHA for 8cfa13f

• Use _.times in _.unzip

  jgonggrijp

  committed
  8edde7b

  Copy full SHA for 8edde7b

• Use linearSearch in collectNonEnumProps, again

  jgonggrijp

  committed
  19ba06e

  Copy full SHA for 19ba06e

• Swap the final parameters of linearSearch

  Show description for 5f46a25
  jgonggrijp

  committed
  5f46a25

  Copy full SHA for 5f46a25

• Rename the final linearSearch parameter

  jgonggrijp

  committed
  dfd6d6b

  Copy full SHA for dfd6d6b

• Use _.lastIndexOf in _.isEqual

  jgonggrijp

  committed
  13fca95

  Copy full SHA for 13fca95

• Use negated isUndefined in _.find

  jgonggrijp

  committed
  457a96d

  Copy full SHA for 457a96d

• Use restArguments in _createAssigner

  jgonggrijp

  committed
  7daecbe

  Copy full SHA for 7daecbe

• Use _.restArguments in _.intersection

  jgonggrijp

  committed
  ce3f0ed

  Copy full SHA for ce3f0ed

• Use _.restArguments in _.partial

  jgonggrijp

  committed
  c654128

  Copy full SHA for c654128

• Enable customization of accumulator initialization in createReduce

  jgonggrijp

  committed
  fca3114

  Copy full SHA for fca3114

• Refactor _.min and _.max (fix jashkenas#2688)

  jgonggrijp

  committed
  8743fc0

  Copy full SHA for 8743fc0

• Use _.find instead of _.reduce in extremum

  jgonggrijp

  committed
  bd49157

  Copy full SHA for bd49157

• Revert "Enable customization of accumulator initialization in createReduce"

  Show description for 5f72f90
  jgonggrijp

  committed
  5f72f90

  Copy full SHA for 5f72f90

• Restore the identity optimization in extremum

  jgonggrijp

  committed
  c71244a

  Copy full SHA for c71244a

• Put back the for loop in extremum

  Show description for e108783
  jgonggrijp

  committed
  e108783

  Copy full SHA for e108783

• Inline compareNumeric in _.min and _.max

  Show description for e2a9a83
  jgonggrijp

  committed
  e2a9a83

  Copy full SHA for e2a9a83

• Use boolean state variable, not shape-shifting callbacks in extremum

  Show description for 448d2e8
  jgonggrijp

  committed
  448d2e8

  Copy full SHA for 448d2e8

• Don't use _.partial anymore in _.min and _.max

  Show description for 5165f1f
  jgonggrijp

  committed
  5165f1f

  Copy full SHA for 5165f1f

• Enable find-by-strict-equality function elision in linearSearch

  Show description for 9bf9dc3
  jgonggrijp

  committed
  9bf9dc3

  Copy full SHA for 9bf9dc3

• Use _.find instead of _.each in createReducer

  jgonggrijp

  committed
  64e62ef

  Copy full SHA for 64e62ef

• Eliminate the dir variable in createReduce

  jgonggrijp

  committed
  aaa0fcb

  Copy full SHA for aaa0fcb

• Reuse the start variable in createIndexFinder

  jgonggrijp

  committed
  01f324e

  Copy full SHA for 01f324e

• Use _.find instead of _.each in _.map

  jgonggrijp

  committed
  6a0ebd8

  Copy full SHA for 6a0ebd8

• Use _.find instead of _.each in internal group

  jgonggrijp

  committed
  7fee0d5

  Copy full SHA for 7fee0d5

• Use _.find instead of _.each in _.filter

  jgonggrijp

  committed
  f60a3ef

  Copy full SHA for f60a3ef

• Use _.times instead of linearSearch in _.chunk

  jgonggrijp

  committed
  ba7df7a

  Copy full SHA for ba7df7a

• Use _.findKey instead of linearSearch in _.mapObject

  jgonggrijp

  committed
  1cb9003

  Copy full SHA for 1cb9003

• Elide createPredicateIndexFinder

  jgonggrijp

  committed
  674ed39

  Copy full SHA for 674ed39

• Slim down predicate elision in linearSearch

  jgonggrijp

  committed
  b7637b6

  Copy full SHA for b7637b6

• Move the identity optimization back to _.min and _.max

  jgonggrijp

  committed
  d5b8d74

  Copy full SHA for d5b8d74

• Inline decideNumeric in _.min and _.max

  jgonggrijp

  committed
  b99a079

  Copy full SHA for b99a079

• Use forward iteration in _.bindAll

  jgonggrijp

  committed
  9de1ceb

  Copy full SHA for 9de1ceb

• Use forward iteration in _.isEqual

  jgonggrijp

  committed
  20e88e5

  Copy full SHA for 20e88e5

• Move the decide parameter out of the way in extremum

  jgonggrijp

  committed
  d82eadc

  Copy full SHA for d82eadc

• Generalize _.sample over the collection types

  jgonggrijp

  committed
  640332b

  Copy full SHA for 640332b

• Restore only the essence of former optimizeCb

  jgonggrijp

  committed
  341ad30

  Copy full SHA for 341ad30

• Replace bindCb by bindCb4 where appropriate

  jgonggrijp

  committed
  eaba5b5

  Copy full SHA for eaba5b5