Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified toCL to be able to run reduce4 mulx example and added the reduce4 mulx example #946

Open
wants to merge 6 commits into
base: cryptoline
Choose a base branch
from

Conversation

JoaoDiogoDuarte
Copy link

Depends on #944 and #945.

This merge request adds:

  • reduce4.jazz example with abstract predicates and asserts/assumes that will result in a valid and correct cryptoline file

And adds the following translations:

  • ADOX
  • ADCX
  • MULX

and changes the IMULr translation to include an assert.

@JoaoDiogoDuarte JoaoDiogoDuarte changed the title Modified toCL to be able to run reduce4 mulx example and added the reduc4 mulx example Modified toCL to be able to run reduce4 mulx example and added the reduce4 mulx example Nov 13, 2024
@eponier eponier requested a review from lyonel2017 December 17, 2024 13:14
@lyonel2017
Copy link
Collaborator

@JoaoDiogoDuarte can you address my previous remarks.

@JoaoDiogoDuarte
Copy link
Author

@JoaoDiogoDuarte can you address my previous remarks.

I'd be happy to, but I don't see any on any remarks in any of the pull requests concerning cryptoline. Do you mind writing them down please? Apologies if you already said them in one of our meetings.

in
instructions

| ADOX ws ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is wrong. The adcs instruction in Cryptoline cannot be used for both ADCX and ADOX in both signed and unsigned mode. I would say adcs can be used for ADCX in unsigned mode, and for ADOX in signed mode. But require to be checked.

compiler/src/toCL.ml Outdated Show resolved Hide resolved
compiler/src/toCL.ml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants