Skip to content

Commit

Permalink
test: skip whatwg url parse and setter tests when icu is missing
Browse files Browse the repository at this point in the history
the WHATWG url parser relies on ICU's punycode implementation.
A handful of the standard tests fail when ICU is not present
because of the additional checks that are not implemented. For
now, skip the parse and setter tests if ICU is not present.

PR-URL: nodejs#9246
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
jasnell committed Oct 25, 2016
1 parent d7e4ae1 commit 52670fc
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
7 changes: 7 additions & 0 deletions test/parallel/test-whatwg-url-parsing.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
'use strict';

const common = require('../common');

if (!common.hasIntl) {
// A handful of the tests fail when ICU is not included.
common.skip('missing Intl... skipping test');
return;
}

const URL = require('url').URL;
const path = require('path');
const assert = require('assert');
Expand Down
7 changes: 7 additions & 0 deletions test/parallel/test-whatwg-url-setters.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
'use strict';

const common = require('../common');

if (!common.hasIntl) {
// A handful of the tests fail when ICU is not included.
common.skip('missing Intl... skipping test');
return;
}

const path = require('path');
const URL = require('url').URL;
const assert = require('assert');
Expand Down

0 comments on commit 52670fc

Please sign in to comment.