Make sure requested pattern is valid #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. 👍 Not quite sure why you rescue exceptions and abort – won't the exceptions end the process properly? Just curious. |
|
I saw that pattern elsewhere while looking for Ruby examples. My Ruby-fu isn't the strongest in a lot of places – would it be better to just remove that block and let it abort normally? |
|
Removed the rescue block and merging. |
jasonlong
pushed a commit
that referenced
this pull request
Feb 21, 2014
Make sure requested pattern is valid
| @@ -81,9 +81,9 @@ def generate_background | |||
|
|
|||
| def generate_pattern | |||
| if opts[:generator] | |||
| begin | |||
| if PATTERNS.include?(opts[:generator].to_sym) | |||
There was a problem hiding this comment.
Not to nit, but could we moved PATTERNS to a frozen array of strings instead of symbols? These symbols are only used as strings and this way we can avoid .to_sym on the passed (potentially user controlled) options. to_sym could lead to a DoS: http://www.ruby-doc.org/core-2.1.0/doc/security_rdoc.html#label-Symbols.
TheBest125
added a commit
to TheBest125/geo_pattern
that referenced
this pull request
Jun 6, 2023
Pre @gregose's comment: jasonlong/geo_pattern#23 (comment) `to_sym` could lead to a DoS: http://www.ruby-doc.org/core-2.1.0/doc/security_rdoc.html#label-Symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a security precaution, this checks that the requested generator is valid before attempting to call it.
/cc @gjtorikian @gregose @andrew