Fix missing hex_val conversions #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the mosaic squares pattern, vals were being sent as strings from the hash without being converted to numeric form first. When val > 9, for examples, opacity incorrectly ends up at its minimum value 37.5% of the time.
|
👍 Good spot, thanks. |
jasonlong
pushed a commit
that referenced
this pull request
Feb 22, 2014
Fix missing hex_val conversions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the mosaic squares pattern, vals were being sent as strings from the hash without being converted to numeric form first. When val > 9, for examples, opacity incorrectly ends up at its minimum value 37.5% of the time.