Random pattern #32
Random pattern #32
Conversation
|
Wow, unbelievable. I remember counting these towards the end (taking into account the 0-based indexing) and must have miscounted. At this point, I think I'm more inclined to remove one of the patterns and keep the pattern choice based on a single SHA value. I'd probably choose to remove @p-lambert Would you like to update your PR to do this? If not, I'm happy to take care of it. We'll need to update the README as well. Either way, thanks for pointing this out! |
|
@jasonlong, I’ll be glad to help. just to be sure if I got it right: should I leave |
|
Yeah, that's what I was thinking. Thanks! On Sun, Mar 9, 2014 at 5:27 PM, Pedro Lambert notifications@github.com
|
|
Looks good, thx @p-lambert. |
In the previous version, there were 17 patterns, and the last one, chevrons, was never randomly displayed. This commit removes the rotatedTriangles pattern and replaces it with chevrons. Ref: jasonlong/geo_pattern#32
Currently, there are 17 available patterns. The last one, “chevrons” has index 16, thus it will be never randomly picked, as
generate_patternuses the 21th hexadecimal character from the hash (which will be 15, at maximum) to pick up a pattern.Thank you very much for this gem!