Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on install and uninstall. #81

Closed
equinox opened this issue Jan 24, 2015 · 11 comments
Closed

Errors on install and uninstall. #81

equinox opened this issue Jan 24, 2015 · 11 comments
Assignees
Milestone

Comments

@equinox
Copy link

equinox commented Jan 24, 2015

I tried this out just before the last update to it, since then, when it updated it gave me an error saying it couldn't install the update then just now when trying to uninstall it's again giving me an error saying it cannot uninstall it.

I'm using Brackets 1.1 and Windows 7.

@nicolo-ribaudo
Copy link
Contributor

You can uninstall the extension by deleting the C:\Users\<Your Username>\AppData\Roaming\Brackets\extensions\user\jasonsanjose.brackets-sass folder.

@jasonsanjose
Copy link
Owner

@Equinoxdawg If you could send me the errors you get on uninstall, that would be great.

  1. Debug > Show Developer Tools
  2. Try Uninstall
  3. Copy console log from dev tools

Thanks!

@equinox
Copy link
Author

equinox commented Jan 30, 2015

I had done what you suggested Nicolo just after posting this issue, thankfully it worked. I have now reinstalled and was able to reproduce. I opened the dev tools, but there was nothing new between opening the tools and it giving me the error and reloading anyway. It now shows after reload: " GET file:///C:/Users/name/AppData/Roaming/Brackets/extensions/user/jasonsanjose.brackets-sass/main.js net::ERR_FILE_NOT_FOUND
ErrorNotification.js:125 [Extension] failed to load C:/Users/name/AppData/Roaming/Brackets/extensions/user/jasonsanjose.brackets-sass - Module does not exist: file:///C:/Users/name/AppData/Roaming/Brackets/extensions/user/jasonsanjose.brackets-sass/main.js"

Edit: I just tried again, and this time as well, there was no errors or anything in the console.

@ofhouse
Copy link

ofhouse commented Feb 26, 2015

When I try to uninstall everything but this file gets deleted.

So I guess this file causes the issue, Debug Console is empty.

@jasonsanjose
Copy link
Owner

I think I know what's causing this now. The compiler runs as a child processes (see https://github.com/jasonsanjose/brackets-sass/blob/master/node/1.1.4-3/SASSDomain.js#L173) and I'm not killing the process when an remove/upgrade happens.

This will be a tricky one to fix and might require something drastic:

  1. Quit and manual delete and/or
  2. Change the extension ID so that the next version is not an upgrade, but a completely separate extension

Let me think about this a bit.

@jasonsanjose
Copy link
Owner

If my theory is right, users should be able to uninstall if the compiler hasn't run in the current session of Brackets. For example:

  1. Quit and restart Brackets
  2. Don't compile or view any .sass/.scss files
  3. Remove the extension via extension manager

Could be the same cause as these uninstall bugs:

This was referenced Feb 26, 2015
@ofhouse
Copy link

ofhouse commented Feb 26, 2015

@jasonsanjose I've tested it (started Brackets with no files open & empty project-folder) but still got the same error on uninstalling.

The workaround does not work I guess ^^

@jasonsanjose
Copy link
Owner

@ofhouse can you try a manual uninstall (instead of extension manager) instead? https://github.com/jasonsanjose/brackets-sass/wiki/Manual-Uninstall

@jasonsanjose jasonsanjose added this to the v2.0 milestone Mar 3, 2015
@nicolo-ribaudo
Copy link
Contributor

@jasonsanjose Are you working on this bug?

Edit:
#107

@jasonsanjose
Copy link
Owner

Not currently. I'll take a look at you PR. Thanks!

@bitbay
Copy link

bitbay commented Mar 22, 2015

Quoting the wiki:

Some users have reported issues on Windows that prevent uninstalling the extension.

Same issue on Debian as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants