TD-1526: add support for EIP-712 bulk listing types #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdymalla
force-pushed
the
master
branch
3 times, most recently
from
0967ace to
7a2cd00
Compare
naveen-imtb
reviewed
Jul 17, 2024
| @@ -216,8 +216,9 @@ func (t *Type) isArray() bool { | |||
| // typeName returns the canonical name of the type. If the type is 'Person[]', then | |||
There was a problem hiding this comment.
@mdymalla nit: update comment to reflect fixed size arrays.
pano-skylakis
approved these changes
Jul 18, 2024
jasonzwli
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk listing types can reference a tree structure from the primary type in the EIP-712 object, this currently works out of the box in typescript and the SDK however fails in
go-ethereum. This package currently does not allow for types to be declared as fixed-sized arrays, so when a bulk listing tree structure is declared, e.g.OrderComponents[2][2]validation will fail. This change adds fixed-size arrays to be expected along with already supported dynamic arrays.Seaport ref for bulk order structure - https://github.com/ProjectOpenSea/seaport/blob/main/docs/SeaportDocumentation.md#bulk-order-signing-and-structure