Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Meta-Analysis #2597

Merged

Conversation

JanGVoelkel
Copy link
Contributor

Fixes the issues that after refreshing the JASP Meta-Analysis file from the data library, JASP kept loading but nothing ever happened

Fixes the issues that after refreshing the JASP Meta-Analysis file from the data library, JASP kept loading but nothing ever happened
@JanGVoelkel JanGVoelkel requested a review from AlexanderLyNL June 5, 2018 11:34
Copy link
Contributor

@AlexanderLyNL AlexanderLyNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that this is a hack or a proper fix?

@JanGVoelkel
Copy link
Contributor Author

It adds a new default options in case the usual assignment does not work. But yeah it is not a very nice fix.

@FransMeerhoff FransMeerhoff merged commit a8a25fc into jasp-stats:development Jun 5, 2018
@JanGVoelkel JanGVoelkel deleted the ReleaseFixMetaAnalysis branch July 20, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants