Add auto-derivation #27
Conversation
ghostbuster91
force-pushed
the
auto-derivation
branch
2 times, most recently
from
515e5e5
to
bdd4305
Compare
| @@ -0,0 +1,3 @@ | |||
| package difflicious | |||
|
|
|||
| case class Derived[T](differ: Differ[T]) | |||
There was a problem hiding this comment.
This can be also implemented as in circe - Derived[T](instance: T), this way it could support multiple typeclasses but it is not necessary in our case. Not sure if there are any other pros and cons.
There was a problem hiding this comment.
I think this is fine though I wonder whether something like
trait DerivedDiffer[T] extends Differ[T] {
def underlying: Differ[T]
}
Will be more ergonomic. Will try it out later
ghostbuster91
force-pushed
the
auto-derivation
branch
3 times, most recently
from
9c6d22d
to
e3ed246
Compare
|
@jatcwang before I move any further with this PR, could you provide some feedback? Is this the approach that you have in mind? |
|
Thanks for this. Feel free to merge this into core module instead of a separate module :) |
ghostbuster91
force-pushed
the
auto-derivation
branch
from
56e0e47
to
f9cb57c
Compare
|
|
||
| for scala 3 | ||
| ```scala | ||
| import difflicious.generic.auto.given |
There was a problem hiding this comment.
@ghostbuster91 You had import difflicious.generic.auto._ here before too but I think it's not needed? I removed it from the docs and tests. Let me know if it needs to be for any reason
There was a problem hiding this comment.
Ah indeed, it was redundant, good catch!
|
Thank you! |
The goal of this PR is to add support for auto-derivation in difficious.