Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration for Weaver test framework #30

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

gregorath
Copy link
Contributor

hello, thanks for this project.

With this PR we are adding support for the weaver framework and I followed the structure of the scalatest module.
I didn't open an issue before as I think this is a small change.

@gregorath
Copy link
Contributor Author

gregorath commented Aug 7, 2023

it looks like there is incompatibility between the scala 3 versions from weaver and difflicious. would it be ok to upgrade to 3.2.2 or even to the LTS 3.3.0 one? I tested it locally and seems okay.
sorry I didn't realise I had to pass the 3 version for the compilation command before opening the PR

@jatcwang
Copy link
Owner

jatcwang commented Aug 7, 2023

@gregorath Yes we should upgrade to 3.3.0 feel free to modify in this PR (will need to run sbt githubWorkflowGenerate to regenerate ci.yaml too).
Don't worry about forgetting to run all 3 compile versions. That's what CI's for :) Thanks!

@gregorath
Copy link
Contributor Author

okay version updated 👍

@gregorath
Copy link
Contributor Author

and I had to update the expected error message in one of the tests, done in 0d1a59a

@jatcwang jatcwang merged commit ee39e6e into jatcwang:master Aug 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants