Skip to content

Commit

Permalink
Address review comments:
Browse files Browse the repository at this point in the history
- rename CHANGES.md section from "Breaking Changes" to "Important Changes"
- add entries for darwin-ppc and darwin-x86 to build system so that
  interested parties can more easily build JNA for old architectures
  • Loading branch information
matthiasblaesing committed Feb 18, 2021
1 parent a19f127 commit 84ab3d2
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ Bug Fixes
---------


Breaking Changes
----------------
Important Changes
-----------------
* `RESOURCE_PREFIX` for darwin (mac OS) was changed from `darwin` to
`darwin-$arch` as the fat binaries on mac OS causes various problems:
It was reported, that binaries were rejected from the appstore because x86
Expand Down
15 changes: 15 additions & 0 deletions build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,12 @@ processor=x86;osname=openbsd,
com/sun/jna/openbsd-x86-64/libjnidispatch.so;
processor=x86-64;osname=openbsd,
com/sun/jna/darwin-ppc/libjnidispatch.jnilib;
osname=macosx;processor=ppc,
com/sun/jna/darwin-ppc64/libjnidispatch.jnilib;
osname=macosx;processor=ppc64,
com/sun/jna/darwin-x86/libjnidispatch.jnilib;
osname=macosx;processor=x86,
com/sun/jna/darwin-x86-64/libjnidispatch.jnilib;
osname=macosx;processor=x86-64,
com/sun/jna/darwin-aarch64/libjnidispatch.jnilib;
Expand Down Expand Up @@ -567,6 +573,15 @@ osname=macosx;processor=aarch64
<zipfileset src="${lib.native}/aix-ppc64.jar"
includes="*jnidispatch*"
prefix="com/sun/jna/aix-ppc64"/>
<zipfileset src="${lib.native}/darwin-ppc.jar"
includes="*jnidispatch*"
prefix="com/sun/jna/darwin-ppc"/>
<zipfileset src="${lib.native}/darwin-ppc64.jar"
includes="*jnidispatch*"
prefix="com/sun/jna/darwin-ppc64"/>
<zipfileset src="${lib.native}/darwin-x86.jar"
includes="*jnidispatch*"
prefix="com/sun/jna/darwin-x86"/>
<zipfileset src="${lib.native}/darwin-x86-64.jar"
includes="*jnidispatch*"
prefix="com/sun/jna/darwin-x86-64"/>
Expand Down
Binary file added lib/native/darwin-ppc.jar
Binary file not shown.
Binary file added lib/native/darwin-ppc64.jar
Binary file not shown.
Binary file added lib/native/darwin-x86.jar
Binary file not shown.

0 comments on commit 84ab3d2

Please sign in to comment.