-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory.dispose() does not remove "this" from the allocatedMemory map #697
Comments
Good catch. Could you provide a PR with the fix and an associated test? On Tue, Aug 30, 2016 at 3:33 AM, AgnetaWalterscheidt <
|
Motivation: These methods should be marked as private-package as its arguments are also package-private Modifications: Fix visibility Result: Cleanup
Method Memory.dispose() frees the peer and sets it to 0. Afterwards it calls allocatedMemory.remove(this). This call does not find the Memory in the map: Memory is a subclass of Pointer which uses the peer for hashcode() and equals() and therefore "this" is no longer equal to the Memory that was put in the map.
This bug is easy to fix by first calling allocatedMemory.remove(this) and then setting the peer to 0.
The text was updated successfully, but these errors were encountered: