Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inactive OSGi manifest headers #71

Closed
jglick opened this issue May 2, 2012 · 4 comments
Closed

Inactive OSGi manifest headers #71

jglick opened this issue May 2, 2012 · 4 comments

Comments

@jglick
Copy link

jglick commented May 2, 2012

jna-3.4.0.jar's manifest contains various OSGi-related attributes such as Bundle-SymbolicName. However these are all within the section named com/sun/jna/, whereas OSGi only interprets attributes in the main section of the manifest. (*) So as far as I know none of these do anything at all. Intentional or mistake?

(*) As opposed to Specification-Version and the like which are defined by the JAR specification and are supposed to be in a named section. Hardly anything pays attention to these attributes, though java.lang.Package can be used to introspect them.
@twall
Copy link
Contributor

twall commented May 2, 2012

On May 2, 2012, at 5:40 PM, Jesse Glick wrote:

jna-3.4.0.jar's manifest contains various OSGi-related attributes such as Bundle-SymbolicName. However these are all within the section named com/sun/jna/, whereas OSGi only interprets attributes in the main section of the manifest. (*) So as far as I know none of these do anything at all. Intentional or mistake?

Simply a mistake. I don't recall where the com/sun/jna section even came from in the first place.

(*) As opposed to Specification-Version and the like which are defined by the JAR specification and are supposed to be in a named section. Hardly anything pays attention to these attributes, though java.lang.Package can be used to introspect them.

Reply to this email directly or view it on GitHub:
#71

@jglick
Copy link
Author

jglick commented May 2, 2012

Well the section is supposed to be there, as I said, for old-style JAR versioning attributes. It is just the placement of OSGi attributes in it that is wrong.

I can make this into a pull request if you would like, though it should be pretty trivial: just move the OSGi-related attributes outside of <section>.

@twall
Copy link
Contributor

twall commented May 3, 2012

I'll see if I can tweak it today sometime.

On May 2, 2012, at 7:29 PM, Jesse Glick wrote:

Well the section is supposed to be there, as I said, for old-style JAR versioning attributes. It is just the placement of OSGi attributes in it that is wrong.

I can make this into a pull request if you would like, though it should be pretty trivial: just move the OSGi-related attributes outside of <section>.

Reply to this email directly or view it on GitHub:
#71 (comment)

@jglick
Copy link
Author

jglick commented May 3, 2012

I guess a duplicate of issue #63.

twall added a commit that referenced this issue Jun 8, 2012
@twall
fix OSGI entries (closes issue #71 and issue #63)
0bfd959
@twall twall closed this as completed Jun 8, 2012
mstyura pushed a commit to mstyura/jna that referenced this issue Sep 9, 2024
@normanmaurer
Generate new connection id when no tokens are used (java-native-acces…
0e46061 
…s#71)

Motivation:

When no tokens are used we should generate a new connection id and not use dcid

Modifications:

- Generate new id and pass it to accept(...)
- Adjust unit test to ensure that the mapping from id to channel still works

Result:

Correctly handle the case for no token usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jglick @twall