Added SetPriorityClass() and SetThreadPriority() to Kernel32 #1544

dEajL3kA · 2023-08-08T09:28:23Z

Added functions GetPriorityClass(), SetPriorityClass(), GetThreadPriority() and SetThreadPriority() to Kernel32 class. Also added some useful helper methods to Kernel32Util class.

Some refactoring of error handling in Kernel32Util class has been done too (avoids "copy & paste" code).

matthiasblaesing · 2023-08-08T20:48:26Z

Please don't close PRs with comments, you can update the PR in place and after review squash if/as necessary.

dblock · 2023-08-10T19:27:25Z

Add tests please for all new methods. Add to CHANGELOG.
Consider splitting up the new methods added in Kernel32 into a separate PR with its tests, will be easier to grok.

dEajL3kA · 2023-08-11T08:58:02Z

Add tests please for all new methods. Add to CHANGELOG.

Test cases have been added
CHANGELOG has been updated

dblock · 2023-08-11T14:17:09Z

CHANGES.md

@@ -8,6 +8,7 @@ Next Release (5.14.0)
 Features
 --------
 * [#1534](https://github.com/java-native-access/jna/pull/1534): Add `GetMethod`, `Put`, `SpawnInstance` to `c.s.j.p.win32.COM.WbemCli#IWbemClassObject` and `ExecMethod` to `c.s.j.p.win32.COM.WbemCli#IWbemServices` - [@faddom](https://github.com/faddom).
+* [#1544](https://github.com/java-native-access/jna/pull/1544): Add `SetPriorityClass` and `SetThreadPriority()` and associated constants to `c.s.j.p.win32.Kernel32`.


Add your name to match format of other entries, please?

dblock · 2023-08-11T14:21:55Z

contrib/platform/test/com/sun/jna/platform/win32/Kernel32UtilTest.java

+            Kernel32Util.setCurrentProcessPriority(Kernel32.HIGH_PRIORITY_CLASS);
+        } catch (Win32Exception e) {
+            fail("setCurrentProcessPriority() failed: " + e.getMessage());
+        }


I don't think we have this pattern anywhere else in tests - I wouldn't catch and assert an expectation like elsewhere. If there's an exception the test will fail anyway.

assertTrue( Kernel32Util.setCurrentProcessPriority(Kernel32.HIGH_PRIORITY_CLASS));

dEajL3kA · 2023-08-14T08:34:40Z

I don't think we have this pattern anywhere else in tests - I wouldn't catch and assert an expectation like elsewhere. If there's an exception the test will fail anyway.

Okay, I have changed the test pattern to not catch the Win32Exception exception.

I think assertTrue() is not required/possible here, as setCurrentProcessPriority() and friends have a void return type.

(That is in accordance with other existing Kernel32Util methods)

Add your name to match format of other entries, please?

Done.

dblock

See test/lint failures above, pls.

dblock · 2023-08-14T12:46:12Z

contrib/platform/test/com/sun/jna/platform/win32/Kernel32UtilTest.java

+    }
+
+    public void testSetCurrentThreadPriority() {
+        Kernel32Util.setCurrentThreadPriority(Kernel32.THREAD_PRIORITY_ABOVE_NORMAL);


You could add GetThreadPriority and similar and check that this actually worked.

dEajL3kA · 2023-08-14T13:39:31Z

GetPriorityClass() and GetThreadPriority() have been added!

I'm not sure that SetPriorityClass() followed by GetPriorityClass() (or SetThreadPriority() followed by GetThreadPriority()) is a good test. There is no guarantee that the priority remains the same in between the function calls.

(The two function calls are not "atomic", i.e. something else may change the priority in between 😟)

Also, as long as SetPriorityClass() or SetThreadPriority() return TRUE, we can be confident that they have succeeded.

dblock

Looks good, will merge on green. See some nice to have ideas about improving tests.

dblock · 2023-08-14T16:38:54Z

contrib/platform/test/com/sun/jna/platform/win32/Kernel32Test.java

+    }
+
+    public void testGetThreadPriority() {
+        final HANDLE selfHandle = Kernel32.INSTANCE.GetCurrentProcess();


Add a test that uses current thread, which should work?

If you want negative tests, maybe GetThreadPriority(INVALID_HANDLE)?

dblock · 2023-08-14T16:39:20Z

contrib/platform/test/com/sun/jna/platform/win32/Kernel32UtilTest.java

@@ -513,4 +513,40 @@ public void testGetLogicalProcessorInformationEx() {
            assertTrue(cache.associativity == WinNT.CACHE_FULLY_ASSOCIATIVE || cache.associativity > 0);
        }
    }
+
+    public void testGetCurrentProcessPriority() {
+        Kernel32Util.getCurrentProcessPriority();


Maybe assert that it's within range? Same for the others?

dEajL3kA · 2023-08-15T09:08:13Z

Maybe assert that it's within range? Same for the others?

Range checks have been added ✔

Also added separate setCurrentProcessBackgroundMode() and setCurrentThreadBackgroundMode() methods, as the "background mode" flags only work with the "current" process or "current" thread handle, respectively.

dEajL3kA · 2023-08-15T14:25:41Z

Some build fixes have been applied ✔

dblock · 2023-08-15T21:55:31Z

Checkstyle still failing in https://github.com/java-native-access/jna/actions/runs/5868437530/job/15923001266?pr=1544, sorry :(

dEajL3kA · 2023-08-16T06:59:08Z

Checkstyle still failing in https://github.com/java-native-access/jna/actions/runs/5868437530/job/15923001266?pr=1544, sorry :(

Okay, should be fixed now, hopefully ✔

BTW: Is there a way how I could figure out such "cosmetic" problems in advanced? Seems a bit "trial and error" right now.

…ty() and SetThreadPriority() methods to Kernel32 class. Added test cases for Kernel32.SetPriorityClass(), Kernel32.GetPriorityClass(), Kernel32.GetThreadPriority() and Kernel32.SetThreadPriority(). Also added some useful helper methods to Kernel32Util class, including tests.

dblock · 2023-08-16T15:44:46Z

The failures in JDK19/20 look unrelated, I opened #1546

dEajL3kA · 2023-08-16T16:06:36Z

🎉

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.223.0` -> `^0.224.0`](https://renovatebot.com/diffs/npm/flow-bin/0.223.0/0.224.0) | | [org.postgresql:postgresql](https://jdbc.postgresql.org) ([source](https://github.com/pgjdbc/pgjdbc)) | build | patch | `42.7.0` -> `42.7.1` | | [net.java.dev.jna:jna](https://github.com/java-native-access/jna) | compile | minor | `5.13.0` -> `5.14.0` | | [org.hibernate.orm:hibernate-envers](https://hibernate.org/orm) ([source](https://github.com/hibernate/hibernate-orm)) | build | patch | `6.4.0.Final` -> `6.4.1.Final` | | [org.hibernate.orm:hibernate-core](https://hibernate.org/orm) ([source](https://github.com/hibernate/hibernate-orm)) | build | patch | `6.4.0.Final` -> `6.4.1.Final` | | [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) | build | patch | `2.41.0` -> `2.41.1` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `3.6.0` -> `3.6.3` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | patch | `3.6.0` -> `3.6.3` | --- ### Release Notes <details> <summary>flowtype/flow-bin</summary> ### [`v0.224.0`](flow/flow-bin@e730887...e6104a1) [Compare Source](flow/flow-bin@e730887...e6104a1) ### [`v0.223.3`](flow/flow-bin@6e1e3f7...e730887) [Compare Source](flow/flow-bin@6e1e3f7...e730887) ### [`v0.223.2`](flow/flow-bin@5bb7bcf...6e1e3f7) [Compare Source](flow/flow-bin@5bb7bcf...6e1e3f7) </details> <details> <summary>pgjdbc/pgjdbc</summary> ### [`v42.7.1`](https://github.com/pgjdbc/pgjdbc/blob/HEAD/CHANGELOG.md#4271-2023-12-06-083400--0500) ##### Changed - perf: improve performance of PreparedStatement.setBlob, BlobInputStream, and BlobOutputStream with dynamic buffer sizing [MR #3044](pgjdbc/pgjdbc#3044) ##### Fixed - fix: Apply connectTimeout before SSLSocket.startHandshake to avoid infinite wait in case the connection is broken [MR #3040](pgjdbc/pgjdbc#3040) - fix: support waffle-jna 2.x and 3.x by using reflective approach for ManagedSecBufferDesc [MR #2720](pgjdbc/pgjdbc#2720) Fixes [Issue #2690](pgjdbc/pgjdbc#2720). - fix: NoSuchMethodError on ByteBuffer#position When Running on Java 8 when accessing arrays, fixes [Issue #3014](pgjdbc/pgjdbc#3014) - Revert "[MR #2925](pgjdbc/pgjdbc#2925) Use canonical DateStyle name" [MR #3035](pgjdbc/pgjdbc#3035) Fixes [Issue #3008](pgjdbc/pgjdbc#3008) - Revert "[MR ##2973](pgjdbc/pgjdbc#2973) feat: support SET statements combining with other queries with semicolon in PreparedStatement" [MR #3010](pgjdbc/pgjdbc#3010) Fixes [Issue #3007](pgjdbc/pgjdbc#3007) - fix: avoid timezone conversions when sending LocalDateTime to the database [#2852](pgjdbc/pgjdbc#3010) Fixes [Issue #1390](pgjdbc/pgjdbc#1390) ,[Issue #2850](pgjdbc/pgjdbc#2850) Closes \[Issue [#1391](pgjdbc/pgjdbc#1391) </details> <details> <summary>java-native-access/jna</summary> ### [`v5.14.0`](https://github.com/java-native-access/jna/blob/HEAD/CHANGES.md#Release-5140) [Compare Source](java-native-access/jna@5.13.0...5.14.0) \============== ## Features - [#1556](java-native-access/jna#1556): Add `SetJob`, `SetPrinter` to `c.s.j.p.w.Winspool` - [@tresf](https://github.com/tresf). - [#1534](java-native-access/jna#1534): Add `GetMethod`, `Put`, `SpawnInstance` to `c.s.j.p.win32.COM.WbemCli#IWbemClassObject` and `ExecMethod` to `c.s.j.p.win32.COM.WbemCli#IWbemServices` - [@faddom](https://github.com/faddom). - [#1544](java-native-access/jna#1544): Add `GetPriorityClass`, `SetPriorityClass`, `GetThreadPriority`, `SetThreadPriority` and associated constants to `c.s.j.p.win32.Kernel32` - [@dEajL3kA](https://github.com/dEajL3kA). - [#1548](java-native-access/jna#1548): Make interface `c.s.j.p.mac.XAttr public` - [@matthiasblaesing](https://github.com/matthiasblaesing). - [#1551](java-native-access/jna#1551): Add `c.s.j.p.bsd.ExtAttr` and `c.s.j.p.bsd.ExtAttrUtil` to wrap BSD [\<sys/extattr.h>](https://man.freebsd.org/cgi/man.cgi?query=extattr\&sektion=2) system calls. [@rednoah](https://github.com/rednoah). - [#1517](java-native-access/jna#1517): Add missing `O_*` (e.g. `O_APPEND`, `O_SYNC`, `O_DIRECT`, ...) to `c.s.j.p.linux.Fcntl` - [@matthiasblaesing](https://github.com/matthiasblaesing). - [#1521](java-native-access/jna#1521): Shutdown CleanerThread once the last cleanable is removed - [@matthiasblaesing](https://github.com/matthiasblaesing). - [#1557](java-native-access/jna#1557): Build linux-riscv64 on Ubuntu focal to improve compatibility with older glibc versions - [@matthiasblaesing](https://github.com/matthiasblaesing). ## Bug Fixes - [#1501](java-native-access/jna#1501): `Library.OPTION_STRING_ENCODING` is ignore for string arguments function calls - [@matthiasblaesing](https://github.com/matthiasblaesing). - [#1504](java-native-access/jna#1504): Increase maximum supported fixed args on varargs calls from 3 to 255 - [@andrew-nowak](https://github.com/andrew-nowak). - [#1545](java-native-access/jna#1545): Fix Java 6 incompatibility in `c.s.j.p.win32.Kerne32Util` and `c.s.j.p.win32.DBT` - [@matthiasblaesing](https://github.com/matthiasblaesing). ## Important Changes - The interfaces between Java and native code have changed, so `libjnidispatch` must be rebuilt to be compatible with this release. - Release drops support for JDKs 6 + 7, so you'll need at least JDK 8 to update to use this version. </details> <details> <summary>hibernate/hibernate-orm</summary> ### [`v6.4.1.Final`](https://github.com/hibernate/hibernate-orm/blob/HEAD/changelog.txt#Changes-in-641Final-December-15-2023) [Compare Source](hibernate/hibernate-orm@6.4.0...6.4.1) https://hibernate.atlassian.net/projects/HHH/versions/32216 \*\* Bug \* \[HHH-17570] - Wrong name provided when checking Oracle autonomous JSON database \* \[HHH-17561] - NullPointerException at OracleServerConfiguration class \* \[HHH-17555] - equals hashcode combined with naturalId \* \[HHH-17553] - java.util.ConcurrentModificationException: null when loading an entity \* \[HHH-17551] - Gradle Enterprise improvements \* \[HHH-17528] - Explicit selection of an [@Embeddable](https://github.com/Embeddable) property containing associated collections doesn't work \* \[HHH-17525] - StackOverflowError when using [@ManyToMany](https://github.com/ManyToMany) with composite id \* \[HHH-17520] - Schema creation fails with interval second data type on PostgreSQL \* \[HHH-17519] - Initializing a lazy association with a non aggregate id causes a NPE \* \[HHH-17515] - DynamicInstantiationResult wrong java type constructor selected \* \[HHH-17499] - SemanticException when querying embedded id entity with positional parameter \* \[HHH-17494] - Metamodel generator produces an uncompilable class when an EntityGraph name contains a comma \* \[HHH-17491] - UnknownEntityTypeException thrown when multiple subclasses define an attribute with the same name and one is a MappedSuperclass \* \[HHH-17489] - ConcurrentModificationException after upgrading to 6.4.0 \* \[HHH-17466] - Exception on query: Could not convert 'java.util.Locale' to 'java.util.Locale' using 'org.hibernate.type.descriptor.java.LocaleJavaType' to wrap \* \[HHH-17464] - 6.4.0 regression: NullPointerException in DefaultEvictEventListener#onEvict \* \[HHH-17456] - java.util.UnknownFormatConversionException thrown why logging set to TRACE \* \[HHH-17445] - Subquery correlated path expressions do not work with nullness predicates \* \[HHH-17418] - Bytecode enchanced read accessor for a final field uses "missing" writer method \* \[HHH-17416] - Using tuples in WHERE clause throws SemanticException \* \[HHH-17413] - Invalid SQL with TYPE() function and CASE expression in SELECT clause \* \[HHH-17408] - Unproxying leads to uninitialized one-to-one associations in some cases involving polymorphism \* \[HHH-17407] - AssertionError when using JpaEntityJoin with correlated subqery if criteria copy tree is enabled \* \[HHH-17405] - Cannot resolve path of generic mapped-superclass association path \* \[HHH-17402] - UnknownEntityTypeException: Unable to locate persister - when comparing generic interface ToOne attribute to parameter \* \[HHH-17397] - Count with right join returns count on the left entity although requested by the right one \* \[HHH-17395] - Refresh with PESSIMISTIC_WRITE ignored for lazy loaded entity \* \[HHH-17393] - Incorrect return type for List attribute, wrap in additional list \* \[HHH-17392] - UnsupportedOperationException when using row_number() window function without top level GROUP BY \* \[HHH-17391] - AssertionError when using row_number() window function with ORDER BY \* \[HHH-17387] - Can't use EAGER ManyToOne on parent abstract class of joined table entity \* \[HHH-17379] - Right join does not return records from the right table if there is condition on ID field and there's no matching record in the from clause \* \[HHH-17359] - Query Cache contains null values for entity associations when entity was already loaded \* \[HHH-17334] - Duplicated columns when updating indexed [@ElementCollection](https://github.com/ElementCollection) with non updatable fields \* \[HHH-17293] - Schema validation fails on postgres interval seconds type \* \[HHH-17280] - UnknownTableReferenceException in subquery selecting embeddable foreign key \* \[HHH-16967] - Missing join on inheritance parent table to validate [@Where](https://github.com/Where) condition \* \[HHH-16756] - orphanRemoval does not work when bytecode enhancement is enabled \* \[HHH-16306] - CountExpressionTest.testCountDistinctTuple fails on Sybase \* \[HHH-16100] - Dynamic-map entity mode does not register a column for one-to-one associations \* \[HHH-1645] - refresh with LockMode on an unitialized proxy does not work \*\* Improvement \* \[HHH-17554] - No join on the table of the parent class with JOINED inheritance strategy when the select not contains a column used in [@Where](https://github.com/Where) or [@SQLRestriction](https://github.com/SQLRestriction) \* \[HHH-16809] - Add JavaType#createArray \*\* Task \* \[HHH-17565] - Add testing for JDK 22-ea \* \[HHH-17546] - Update Cockroach CI testing to 23.1.12 \* \[HHH-17545] - Update SAP HANA JDBC driver to 2.19.11 \* \[HHH-17544] - Update SAP HANA CI testing to 2.00.072.00.20231123.1 \* \[HHH-17543] - Update DB2 CI testing to 11.5.9.0 \* \[HHH-17542] - Update DB2 JDBC driver to 11.5.9.0 \* \[HHH-17541] - Update SQL Server JDBC driver to 12.4.2 </details> <details> <summary>quarkusio/quarkus</summary> ### [`v3.6.3`](https://github.com/quarkusio/quarkus/releases/tag/3.6.3) [Compare Source](quarkusio/quarkus@3.6.2...3.6.3) ##### Complete changelog - [#37690](quarkusio/quarkus#37690) - Regression in 3.6.2: ConfigDiagnostic `NullPointerException: Cannot invoke "java.lang.CharSequence.toString()" because "s" is null` - [#37688](quarkusio/quarkus#37688) - Do not use build cache when releasing - [#37669](quarkusio/quarkus#37669) - OIDC: Fix DEV UI startup when OIDC or Keycloak Dev Services is disabled - [#37667](quarkusio/quarkus#37667) - Disabling of Dev Services for Keycloak leads to startup error - [#37651](quarkusio/quarkus#37651) - Fix GraalVM version checker in order to accept other implementations - [#37563](quarkusio/quarkus#37563) - Consistent file URI for folders and jars - [#37559](quarkusio/quarkus#37559) - Quarkus throws NPE when trying to match unknown config files ### [`v3.6.2`](https://github.com/quarkusio/quarkus/releases/tag/3.6.2) [Compare Source](quarkusio/quarkus@3.6.1...3.6.2) ##### Complete changelog - [#37686](quarkusio/quarkus#37686) - Use standard URL when updating the website - [#37653](quarkusio/quarkus#37653) - Improve error message in REST Client when no matching readers found - [#37640](quarkusio/quarkus#37640) - Handle expireAfterWrite properly in the redis-cache config - [#37639](quarkusio/quarkus#37639) - Logging docs include build time config reference - [#37638](quarkusio/quarkus#37638) - Add scope tag to all injected MP Metrics - [#37623](quarkusio/quarkus#37623) - Add quarkus-funqy-amazon-lambda-deployment to the quarkus-bom - [#37617](quarkusio/quarkus#37617) - SmallRye GraphQL 2.6.1 - [#37611](quarkusio/quarkus#37611) - Fix configuration of custom port for Elasticsearch dev services - [#37610](quarkusio/quarkus#37610) - Elasticsearch devservice port incorrect binding - [#37605](quarkusio/quarkus#37605) - Fix type in HeartbeatFilter example of rest-client-reactive doc - [#37599](quarkusio/quarkus#37599) - Bump kafka3.version from 3.6.0 to 3.6.1 - [#37594](quarkusio/quarkus#37594) - Bump org.jetbrains.kotlinx:kotlinx-serialization-json from 1.6.1 to 1.6.2 - [#37590](quarkusio/quarkus#37590) - Microprofile Metric Missing "Scope" Tag Only When Using Constructor Injection - [#37588](quarkusio/quarkus#37588) - Update the import.cypher script to use newer syntax - [#37581](quarkusio/quarkus#37581) - Support using commas to add extensions with CLI - [#37570](quarkusio/quarkus#37570) - Prevent concurrently running Jacoco ReportCreators to avoid report corruption - [#37565](quarkusio/quarkus#37565) - ArC: prevent duplicate bean discovery & detect duplicate bean identifiers - [#37564](quarkusio/quarkus#37564) - Invalid documentation for 'quarkus extension add' - [#37557](quarkusio/quarkus#37557) - Make docs/sync-web-site.sh recoverable - [#37553](quarkusio/quarkus#37553) - Register OpenAPI custom filters for reflection - [#37549](quarkusio/quarkus#37549) - Bump commons-io:commons-io from 2.15.0 to 2.15.1 - [#37546](quarkusio/quarkus#37546) - Bump io.quarkus:quarkus-platform-bom-maven-plugin from 0.0.99 to 0.0.100 - [#37545](quarkusio/quarkus#37545) - Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 - [#37536](quarkusio/quarkus#37536) - Fix != expression in `@PreAuthorize` check - [#37535](quarkusio/quarkus#37535) - Fix Snappy note about native - [#37526](quarkusio/quarkus#37526) - Spring security annotatiton PreAuthorize process equals and not equals in the same way - [#37520](quarkusio/quarkus#37520) - Properly match unknown config files for Windows - [#37513](quarkusio/quarkus#37513) - Save pathParamValues encoded and perform decoding when requested - [#37505](quarkusio/quarkus#37505) - Bump org.jboss.logmanager:log4j2-jboss-logmanager from 1.1.1.Final to 1.1.2.Final - [#37496](quarkusio/quarkus#37496) - Quarkus 3.6.0 generate wrong jacoco xml - [#37493](quarkusio/quarkus#37493) - upgrading from quarkus 3.5.3 to 3.6.0 java.lang.IllegalArgumentException: A case block for the string value already exist - [#37479](quarkusio/quarkus#37479) - Redis Cache ttl default value invalid setting - [#37357](quarkusio/quarkus#37357) - Runtime OpenAPI filters are not registered for reflection - [#37298](quarkusio/quarkus#37298) - Bump Keycloak version to 23.0.0 - [#37187](quarkusio/quarkus#37187) - Bump org.apache.commons:commons-compress from 1.24.0 to 1.25.0 - [#37129](quarkusio/quarkus#37129) - Bump org.jetbrains.kotlinx:kotlinx-serialization-json from 1.6.0 to 1.6.1 - [#37128](quarkusio/quarkus#37128) - Bump org.junit:junit-bom from 5.10.0 to 5.10.1 - [#37035](quarkusio/quarkus#37035) - Register methods of RESTeasy reactive parameter containers for reflection - [#36986](quarkusio/quarkus#36986) - Native not index method with SSE and throw NoSuchMethodException - [#36813](quarkusio/quarkus#36813) - config-yaml warning - unrecognized configuration file on Windows - [#36773](quarkusio/quarkus#36773) - "Unrecognized configuration file" when using YAML - [#35960](quarkusio/quarkus#35960) - PathParam URL encoded in quarkus-resteasy-reactive since quarkus 3.2.x ### [`v3.6.1`](https://github.com/quarkusio/quarkus/releases/tag/3.6.1) [Compare Source](quarkusio/quarkus@3.6.0...3.6.1) ##### Complete changelog - [#37486](quarkusio/quarkus#37486) - Revert "Unlist quarkus-resteasy-qute and quarkus-resteasy-reactive-qute" - [#37478](quarkusio/quarkus#37478) - Qute resteasy change in 3.6.0 - [#37454](quarkusio/quarkus#37454) - Config: detect injected config value mismatch for missing values - [#37453](quarkusio/quarkus#37453) - Fix Panache bytecode enhancement for `@Embeddable` records - [#37449](quarkusio/quarkus#37449) - Update Apache Maven to 3.9.6 - [#37447](quarkusio/quarkus#37447) - Add Content-Range header to 206 Partial Content file response - [#37444](quarkusio/quarkus#37444) - Injecting ConfigProperty of type Optional\<List<String>> not working in the native mode - [#37436](quarkusio/quarkus#37436) - Respect comma escapes in property value for `@RolesAllowed.` - [#37428](quarkusio/quarkus#37428) - Fix various minor issues in quarkus update - [#37426](quarkusio/quarkus#37426) - Fix typo configMapRefKey -> configMapKeyRef - [#37421](quarkusio/quarkus#37421) - Scheduler: register ApplicationNotRunning as bean even if quartz is used - [#37417](quarkusio/quarkus#37417) - Build fails when using the Quartz extension and `@Scheduled`(..., skipExecutionIf = Scheduled.ApplicationNotRunning.class) - [#37415](quarkusio/quarkus#37415) - Make Truffle from GraalVM 23.1 work in all Quarkus modes - [#37401](quarkusio/quarkus#37401) - Print correct profiles in native image - [#37400](quarkusio/quarkus#37400) - Improve reliability when downloading builder images from Quay.io - [#37398](quarkusio/quarkus#37398) - Revert "Build cache - Upload quarkus-ide-launcher-999-SNAPSHOT.jar" - [#37395](quarkusio/quarkus#37395) - Update Gradle to 8.5 - [#37393](quarkusio/quarkus#37393) - Disable new Http2RSTFloodProtectionConfigTest on Windows - [#37392](quarkusio/quarkus#37392) - Update gradle to 8.5 and backport if possible to finish Java 21 dependencies - [#37384](quarkusio/quarkus#37384) - Stop disabling unsafe in netty at native-executable runtime - [#37382](quarkusio/quarkus#37382) - Update MAX_LTS_SUPPORTED_BY_KOTLIN to 21 - [#37367](quarkusio/quarkus#37367) - Documentation: security auth mechanism guide must also list runtime form auth properties alongside build-time ones - [#37366](quarkusio/quarkus#37366) - Documentation: Fix OIDC credentials reference to secret key - [#37364](quarkusio/quarkus#37364) - Improve Docker Desktop detection - [#37361](quarkusio/quarkus#37361) - Do not fail the request in OidcClient filters if OidcClient is disabled - [#37360](quarkusio/quarkus#37360) - Disable OidcClientFilter at runtime for simpler application testing - [#37359](quarkusio/quarkus#37359) - Fix incorrect log dependency - [#37354](quarkusio/quarkus#37354) - Update Boucycastle to 1.77 and Boucycastle FIPS to 1.0.2.4 - [#37351](quarkusio/quarkus#37351) - Upgrade to Jandex 3.1.6 - [#37350](quarkusio/quarkus#37350) - Unlist quarkus-resteasy-reactive-qute and quarkus-resteasy-qute - [#37347](quarkusio/quarkus#37347) - Runtime (re)initialize Netty's PlatformDependent classes - [#37318](quarkusio/quarkus#37318) - Use batch mode for update-version.sh - [#37317](quarkusio/quarkus#37317) - Avoid asking for GPG passphrase on CI - [#37314](quarkusio/quarkus#37314) - Fix deprecated dev-v1 url with dev-ui in a few places - [#37300](quarkusio/quarkus#37300) - Prepare docs/sync-web-site.sh for automated releases - [#37294](quarkusio/quarkus#37294) - Fix the major version of Java 21 - [#37292](quarkusio/quarkus#37292) - Bump testcontainers to 1.19.3 and use docker-java-bom - [#37291](quarkusio/quarkus#37291) - Bump org.jetbrains.kotlin:kotlin-gradle-plugin-api from 1.9.20 to 1.9.21 in /devtools/gradle - [#37280](quarkusio/quarkus#37280) - Bump Microsoft SQL Server JDBC driver to 12.4.2 - [#37279](quarkusio/quarkus#37279) - Bump Microsoft SQL Server JDBC driver to 12.4.2 - [#37271](quarkusio/quarkus#37271) - Docs: add keywords to Vert.x guides - [#37270](quarkusio/quarkus#37270) - Vert.x: report exception for blocking message consumer methods - [#37268](quarkusio/quarkus#37268) - Reactive REST Client: check for ClientRequestFilter when skipping `@Provider` auto-discovery - [#37252](quarkusio/quarkus#37252) - Use the default tenant resolver if the custom one does not resolve a tenant - [#37251](quarkusio/quarkus#37251) - Add a test showing how OIDC ID token can be propagated - [#37247](quarkusio/quarkus#37247) - Update kindcontainer to 1.4.4 - [#37244](quarkusio/quarkus#37244) - Always execute a JPA password action - [#37228](quarkusio/quarkus#37228) - Add classes from additional JPA model build items to pre-generate proxies - [#37224](quarkusio/quarkus#37224) - Qute: dev mode - debug a problem with no-restart-template - [#37222](quarkusio/quarkus#37222) - RuntimeException in vertx is silently swallowed for blocking ConsumeEvents - [#37177](quarkusio/quarkus#37177) - QUARKUS_MROFILE=dev and '-Dquarkus.profile=dev' not working for native image - [#37108](quarkusio/quarkus#37108) - Warning about build time generated proxy for entity OutboxEvent in Hibernate Search - [#36892](quarkusio/quarkus#36892) - Update Kotlin to version 1.9.21, Mockito to 5.7.0 - [#36747](quarkusio/quarkus#36747) - NoSuchMethodException when reading `@Embeddable` record - [#36735](quarkusio/quarkus#36735) - Failure to bump BouncyCastle FIPS version to 1.0.2.4 due to a native build failure - [#36242](quarkusio/quarkus#36242) - Quarkus cannot load Truffle/polyglot languages with the custom class loader. - [#17839](quarkusio/quarkus#17839) - Invalid memory configuration for netty maxDirectMemory in native image </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v3.6.3`](quarkusio/quarkus-platform@3.6.2...3.6.3) [Compare Source](quarkusio/quarkus-platform@3.6.2...3.6.3) ### [`v3.6.2`](quarkusio/quarkus-platform@3.6.1...3.6.2) [Compare Source](quarkusio/quarkus-platform@3.6.1...3.6.2) ### [`v3.6.1`](quarkusio/quarkus-platform@3.6.0...3.6.1) [Compare Source](quarkusio/quarkus-platform@3.6.0...3.6.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

dEajL3kA mentioned this pull request Aug 11, 2023

Kernel32.INSTANCE.SetPriorityClass is missing! #1538

Closed

dEajL3kA force-pushed the master branch from f7260c8 to 519f640 Compare August 11, 2023 08:54

dblock reviewed Aug 11, 2023

View reviewed changes

dEajL3kA force-pushed the master branch 2 times, most recently from ad93b9c to 1669000 Compare August 14, 2023 08:32

dEajL3kA force-pushed the master branch from 1669000 to af6b9ce Compare August 14, 2023 11:03

dblock reviewed Aug 14, 2023

View reviewed changes

dEajL3kA force-pushed the master branch from af6b9ce to f698f73 Compare August 14, 2023 13:31

dEajL3kA force-pushed the master branch 5 times, most recently from 30eeb76 to f7ae348 Compare August 14, 2023 14:29

dblock approved these changes Aug 14, 2023

View reviewed changes

dEajL3kA force-pushed the master branch from f7ae348 to f318fb9 Compare August 15, 2023 09:07

dEajL3kA force-pushed the master branch 3 times, most recently from 64f6308 to 4cf2c69 Compare August 15, 2023 14:24

Refactored error handling.

263f074

dEajL3kA force-pushed the master branch from 4cf2c69 to ae2c95e Compare August 15, 2023 14:49

dEajL3kA force-pushed the master branch 2 times, most recently from bde37f5 to 7226090 Compare August 16, 2023 06:58

dEajL3kA added 2 commits August 16, 2023 09:14

Updated changelog.

b5bd187

dEajL3kA force-pushed the master branch from 7226090 to b5bd187 Compare August 16, 2023 07:14

dblock merged commit cf94e00 into java-native-access:master Aug 16, 2023
8 of 10 checks passed

This was referenced Aug 16, 2023

SetPriorityClass() and SetThreadPriority() are missing from Kernel32 class #1539

Closed

Refactoring request (Kernel32.java) #1542

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added SetPriorityClass() and SetThreadPriority() to Kernel32 #1544

Added SetPriorityClass() and SetThreadPriority() to Kernel32 #1544

dEajL3kA commented Aug 8, 2023 •

edited

Loading

matthiasblaesing commented Aug 8, 2023

dblock commented Aug 10, 2023

dEajL3kA commented Aug 11, 2023 •

edited

Loading

dblock Aug 11, 2023

dblock Aug 11, 2023

dEajL3kA commented Aug 14, 2023 •

edited

Loading

dblock left a comment

dblock Aug 14, 2023

dEajL3kA commented Aug 14, 2023 •

edited

Loading

dblock left a comment

dblock Aug 14, 2023

dblock Aug 14, 2023

dEajL3kA commented Aug 15, 2023 •

edited

Loading

dEajL3kA commented Aug 15, 2023

dblock commented Aug 15, 2023

dEajL3kA commented Aug 16, 2023 •

edited

Loading

dblock commented Aug 16, 2023

dEajL3kA commented Aug 16, 2023

Added SetPriorityClass() and SetThreadPriority() to Kernel32 #1544

Added SetPriorityClass() and SetThreadPriority() to Kernel32 #1544

Conversation

dEajL3kA commented Aug 8, 2023 • edited Loading

matthiasblaesing commented Aug 8, 2023

dblock commented Aug 10, 2023

dEajL3kA commented Aug 11, 2023 • edited Loading

dblock Aug 11, 2023

Choose a reason for hiding this comment

dblock Aug 11, 2023

Choose a reason for hiding this comment

dEajL3kA commented Aug 14, 2023 • edited Loading

dblock left a comment

Choose a reason for hiding this comment

dblock Aug 14, 2023

Choose a reason for hiding this comment

dEajL3kA commented Aug 14, 2023 • edited Loading

dblock left a comment

Choose a reason for hiding this comment

dblock Aug 14, 2023

Choose a reason for hiding this comment

dblock Aug 14, 2023

Choose a reason for hiding this comment

dEajL3kA commented Aug 15, 2023 • edited Loading

dEajL3kA commented Aug 15, 2023

dblock commented Aug 15, 2023

dEajL3kA commented Aug 16, 2023 • edited Loading

dblock commented Aug 16, 2023

dEajL3kA commented Aug 16, 2023

dEajL3kA commented Aug 8, 2023 •

edited

Loading

dEajL3kA commented Aug 11, 2023 •

edited

Loading

dEajL3kA commented Aug 14, 2023 •

edited

Loading

dEajL3kA commented Aug 14, 2023 •

edited

Loading

dEajL3kA commented Aug 15, 2023 •

edited

Loading

dEajL3kA commented Aug 16, 2023 •

edited

Loading