You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of the aforementioned functions, as well as a few convenient helpers and wrappers. Also modified the internal private fields of SECURITY_DESCRIPTOR_RELATIVE to make getting the Owner, Group and SACL as easy as the DACL.
Also modified the PSID to get the string representation in an easy way.
Yes, you can do that via an --amend and a git push -f. Change the description of the commit as well to be just what you did, a lot in the old unsquashed history is noise - imagine if you were writing this perfect code from scratch, what would the description be? (probably something close to what's in the CHANGELOG).
And thanks for hanging with me through this. I appreciate the guidance. This was my first contribution to an open source project! Been programming closed source C/C++ programs for nearly 15 years. Expect more, by the way, as we have some seriously heavy Windows use cases here.
…ative-access#446)
Motivation:
We also need to ensure we run all SSL tasks when sending data as otherwise we might stale.
Modifications:
- Correctly run all tasks in all cases
- Reenable usage of executor during tests
Result:
Correctly handling tasks offloading for all cases
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the aforementioned functions, as well as a few convenient helpers and wrappers. Also modified the internal private fields of SECURITY_DESCRIPTOR_RELATIVE to make getting the Owner, Group and SACL as easy as the DACL.
Also modified the PSID to get the string representation in an easy way.