Fixed issue #604: Kernel32#GetLastError() always returns ERROR_SUCCESS #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoldstein
changed the title
…turns ERROR_SUCCESS
| @@ -109,7 +109,12 @@ private NativeLibrary(String libraryName, String libraryPath, long handle, Map<S | |||
| synchronized(functions) { | |||
| Function f = new Function(this, "GetLastError", Function.ALT_CONVENTION, encoding) { | |||
| @Override | |||
| Object invoke(Object[] args, Class<?> returnType, boolean b) { | |||
| Object invoke(Object[] args, Class<?> returnType, boolean b, int fixedArgs) { | |||
There was a problem hiding this comment.
I recently changed the lowest-level "invoke" signature when handling interface-based mappings in order to accommodate varargs correctly, as part of a varargs fix for arm. This is transparent to any existing usage, but I neglected to update the signature on this GetLastError short-circuit, with the result being that some (all?) calls directly to GetLastError would no longer be short-circuited.
twall
added a commit
that referenced
this pull request
Mar 6, 2016
Fixed issue #604: Kernel32#GetLastError() always returns ERROR_SUCCESS
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
Motivation: Quiche tagged a new release Modifications: Bump up sha to match latest quiche release Result: Use quiche 0.19.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected required overrides in the "short-circuit" code