Make Win32Exception extend LastErrorException #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoldstein
force-pushed
the
win32-as-last-error
branch
from
7a571ad
to
b9e55b7
Compare
lgoldstein
force-pushed
the
win32-as-last-error
branch
from
b9e55b7
to
21c4f33
Compare
| } | ||
|
|
||
| public LastErrorException(int code) { | ||
| super(formatMessage(code)); | ||
| protected LastErrorException(int code, String msg) { |
There was a problem hiding this comment.
Any particular reason for making this one protected? If so, javadoc would be appropriate.
There was a problem hiding this comment.
Not really, I just thought it would discourage programmers from creating a new instance that contains code and message unless they are using a derived class to do so (e.g., LinuxException, _MacException - similar to Win32Exception). However,I am quite fine with making it public...
There was a problem hiding this comment.
That makes sense to me, you probably never want both. @twall feel free to merge this as is.
twall
added a commit
that referenced
this pull request
Mar 8, 2016
Make Win32Exception extend LastErrorException
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
…ve-access#613) Motivation: We should add toString() implementations for our QuicEvent implementations to make debugging easier. Modifications: Add toString() methods Result: Easier to log / debug events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is only logical since this is what Win32Exception is actually used for