Shell32.SetCurrentProcessExplicitAppUserModelID

[rednoah]

Added functions to Shell32 wrapper which are useful Desktop integration for Java GUI applications (on Windows 7 and higher).

• SetCurrentProcessExplicitAppUserModelID
• GetCurrentProcessExplicitAppUserModelID

[matthiasblaesing]

Could you please free the string, as this is expected from the documentation? For the unittest this is not actually necessary, but people looking at the code might be mislead, that you don't need to free the string.

[matthiasblaesing]

Thank you! I added a few line notes. Please also add an entry to the FEATURES section in CHANGES.md - see the other entries as a template.

[rednoah]

Fixed.

[matthiasblaesing]

Thank you for the changes however this can't be merged - running the unittest immediatly fails:

Testsuite: com.sun.jna.platform.win32.Shell32Test
Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1,895 sec

Testcase: testCurrentProcessExplicitAppUserModelID(com.sun.jna.platform.win32.Shell32Test): FAILED
expected:<[com.sun.jna.platform.win32.Shell32Test]> but was:<[??À?]>
junit.framework.ComparisonFailure: expected:<[com.sun.jna.platform.win32.Shell32Test]> but was:<[??À?]>
    at com.sun.jna.platform.win32.Shell32Test.testCurrentProcessExplicitAppUserModelID(Shell32Test.java:247)

This is easily explained: PointerByReference#getPointer retrieves the Pointer to the PointerBuffer, not the Pointer value that is placed inside the buffer. Both occurences (line 247+ 249) need to be modified.

As the code needs another round I'd like to ask you to review the CHANGES.md entry:

• please move your entry to the end of the FEATURES section (new entries are appended)
• I'd reword it - you implemented both setter+getter, this modification is not only usable for running under javaw, but will also work with other launchers. (not critical!)

As a final note - it would be good if you'd squash the commits into one commit, so that history is not cluttered.

Thank you for your patience!

[rednoah]

Done, but squashing commits... for the love of my life i couldn't figure out how to do that on my branch... Doesn't github have a merge+squash button?

[rednoah]

... no idea why CI fails. That test definitely works on my Windows VM now.