Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

Use HTTP/1.1 to perform readiness check #156

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Use HTTP/1.1 to perform readiness check #156

merged 3 commits into from
Jan 18, 2024

Commits on Jan 18, 2024

  1. Use HTTP/1.1 to perform readiness check 

    This change re-enables the readiness check, using HTTP/1.1 instead of
HTTP/2 to invoke it. The readiness checks are unauthenticated and are
throttled when the feature gate UnauthenticatedHTTP2DOSMitigation is set
to true, which is the default starting in Kubernetes 1.29 (see
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates).
This was the cause of the "GOAWAY received" errors that have been
observed on Kubernetes 1.29.

This change also decouples starting of the servers from waiting until
they become ready, so that if the readiness check fails due to some
error that propagates out of the polling loop (e.g. IOException), the
caller is free to catch it and continue waiting.
    @adriansuarez
    adriansuarez committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    526dffc View commit details
    Browse the repository at this point in the history

  2. Back out decoupling of server start-up and readiness checking

    @adriansuarez
    adriansuarez committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    bea3af2 View commit details
    Browse the repository at this point in the history

  3. Add comment explaining usage of HTTP/1.1

    @adriansuarez
    adriansuarez committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8336465 View commit details
    Browse the repository at this point in the history