feat: able to specify api server flags #46
Conversation
csviri
force-pushed
the
specify-api-server-flag_
branch
from
7c6a61c to
4de5cf2
Compare
| apiServerFlags.add(key); | ||
| } | ||
|
|
||
| private void checkKeyPrefix(String key) { |
There was a problem hiding this comment.
Maybe it'd be better to issue a warning and add the prefix automatically if it's missing to be more user-friendly?
There was a problem hiding this comment.
actually yes, was thinking to ask for the flag without the flag
There was a problem hiding this comment.
it's a problem with the list of flags. I will merge this simple form, and we can do impovements in a subsequent PR.
| private final List<String> apiServerFlags; | ||
|
|
||
| KubeAPIServerConfig(String jenvtestDir, String apiServerVersion, boolean offlineMode, | ||
| List<String> apiServerFlags) { |
There was a problem hiding this comment.
Maybe it could be useful to have a Flag class that would encapsulate things instead of just relying on String pairs (similarly to what's done for micrometer tags)?
There was a problem hiding this comment.
Ahh not sure, it is also some time not a pair, just a single flag name
| "--disable-admission-plugins", "ServiceAccount", | ||
| "--client-ca-file", certManager.getClientCertPath(), | ||
| "--service-cluster-ip-range", "10.0.0.0/24", | ||
| "--allow-privileged")); |
There was a problem hiding this comment.
How would one capture such a parameter if you're supposed to pass pairs?
There was a problem hiding this comment.
there is also api for that. in the builder
No description provided.