This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
feat: ARM-arch is now supported, avoid always recomputing values #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
suggested changes
Mar 24, 2023
| arch = "ppc64le"; | ||
| break; | ||
| case "aarch64": | ||
| arch = "arm64"; |
There was a problem hiding this comment.
there are no binaries for ARM, but on macs this should work with amd64 binaries.
There was a problem hiding this comment.
There are binaries for ARM and, no, amd64 won't work on more recent Macs. I've checked on both, or, at least, tests don't pass on my system without this PR and do with this PR, which I assume means that things work.
There was a problem hiding this comment.
ahh, sorry your are right, I completely missed that
|
Kudos, SonarCloud Quality Gate passed!
|
csviri
approved these changes
Mar 26, 2023
|
would be nice to have an automated test run for this, just probably not possible now with github actions, or IDK |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.