This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
feat: polling default ns #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
reviewed
Mar 28, 2023
| @@ -12,7 +12,7 @@ public class KubeAPIServer implements UnexpectedProcessStopHandler { | |||
|
|
|||
| private static final Logger log = LoggerFactory.getLogger(KubeAPIServer.class); | |||
|
|
|||
| public static final int STARTUP_TIMEOUT = 15_000; | |||
| public static final int STARTUP_TIMEOUT = 10_0000; | |||
There was a problem hiding this comment.
100 seconds? That seems too much to wait.
There was a problem hiding this comment.
yeah that is a mistake
csviri
force-pushed
the
polling-instead-of-watch
branch
from
d3a2805 to
4fffb3a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
replaced by: #56 |
|
Should we remove this branch? And maybe activate automated branch removal on merges? |
|
yeah, deleted, will activate it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.