Added support for evaluation based on bindings. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 17, 2018 22:35
…racter, which makes the test fail. Should not cause any real harm, and we can't really do anything about it.
|
Looks all good! Thank you! I think for that test case we need to accept both '\n' and '\r\n'. Will add that to the test case! |
|
Well, to me it looks like nashorn just uses '\r\n' for the linebreaks when printing. Should look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the feature I'm currently missing. I need to be able to set the specific bindings used for the evaluation, not just a context.
Not a good implementation, just to gets it into the library as quickly as possible.