Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo that causes an error in Safari 9 #19

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

davidmerrique
Copy link
Contributor

toggle is not a variable in that scope. Looks like it should've been target.

This fixes a Can't find variable: toggle error I've been getting in Safari 9.

Thank you!

@davidmerrique davidmerrique changed the title Fix typo that caused an error in Safari 9 Fix a typo that causes an error in Safari 9 Feb 28, 2019
Copy link
Collaborator

@muan muan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@javan: for your reference– 1d17534#diff-1fdf421c05c1140f6d71444ea2b27638R87 and in ☕️ :

@javan javan merged commit 8188bb3 into javan:master Feb 28, 2019
@javan
Copy link
Owner

javan commented Feb 28, 2019

🤦‍♂️ Thank you!

@davidmerrique
Copy link
Contributor Author

@muan @javan Thanks! 🙌🏽

@javan
Copy link
Owner

javan commented Feb 28, 2019

🚢 https://github.com/javan/details-element-polyfill/releases/tag/2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants