Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runner commands use bundle exec (if a Gemfile is present) #536

Closed
wants to merge 1 commit into from

Conversation

judithroth
Copy link
Contributor

When whenever registers a runner command, it doesn’t use bundle exec in the resulting crontab. This may cause errors like this:
'gem_original_require': no such file to load -- bundler/setup (LoadError)

This patch makes whenever runner commands use "bundle exec" when there's a Gemfile present (which indicates use of bundler).

@ajsharp
Copy link

ajsharp commented May 4, 2015

Bump

@benlangfeld
Copy link
Collaborator

Merged as 9f37076. Thank you for the contribution @judithroth!

@benlangfeld benlangfeld closed this Jun 5, 2016
@javan
Copy link
Owner

javan commented Jun 5, 2016

I believe this will construct bundle exec bin/rails runner when both bundler and bin/rails are present, which makes using the bin/rails binstub redundant. I think it'll work fine, just making a note of it.

@benlangfeld
Copy link
Collaborator

It is indeed redundant @javan, but does work. I figured it was better to resolve the bug quickly, and then come up with a consistent answer to binstubs vs bundle exec at lower priority :)

@benlangfeld
Copy link
Collaborator

Also note some people having trouble executing their binstubs directly at #555. We'll have to take that into account if we want to smooth this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants