Update upstream #79
Merged
Update upstream #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ox-webpack-plugin (#1598) * fix empty object on custom plugins * strip comments when parsing custom plugins * use regex instead of strip-comments lib * add test cases for custom plugins * check if function content remains on custom plugin tests * fix misshandled strings with // on runtime-caching-converter * add test case to misshandled // on runtime-caching-converter * fix identation on runtime-caching-converter changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ox-webpack-plugin (GoogleChrome#1598)
fix empty object on custom plugins
strip comments when parsing custom plugins
use regex instead of strip-comments lib
add test cases for custom plugins
check if function content remains on custom plugin tests
fix misshandled strings with // on runtime-caching-converter
add test case to misshandled // on runtime-caching-converter
fix identation on runtime-caching-converter changes
R: @jeffposnick @addyosmani @gauntface
Fixes #issue number
Description of what's changed/fixed.
Please ensure that
gulp lint testpasses locally prior to filing a PR!