Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obfuscator:disable/enable tags not removed from result #641

Closed
ErinPo opened this issue Jun 24, 2020 · 3 comments
Closed

obfuscator:disable/enable tags not removed from result #641

ErinPo opened this issue Jun 24, 2020 · 3 comments
Labels
enhancement

Comments

@ErinPo
Copy link

ErinPo commented Jun 24, 2020

I noticed that when using tag comments likes /* javascript-obfuscator:disable */ that these remain in the output. They should be removed so as not to brand output with the name of a tool.
@sanex3339
Copy link
Member

sanex3339 commented Jun 24, 2020 •
edited
Loading

Yep. This is a good idea.

sanex3339 pushed a commit that referenced this issue Jun 24, 2020
Conditional comments will be removed from the code after obfuscation. #…
733fe12 
…641
@sanex3339 sanex3339 mentioned this issue Jun 24, 2020
Merged
@sanex3339
Copy link
Member

Released as 1.2.0

@sanex3339
Copy link
Member

sanex3339 commented Jun 28, 2020 •
edited
Loading

Released 1.2.2 with a performance regression fix after 1.2.0

@renovate renovate bot mentioned this issue May 25, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanex3339 @ErinPo