Fix bug in groupby checking wrong colDtype #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrseymour
reviewed
Feb 23, 2022
| @@ -262,7 +262,8 @@ export default class Groupby { | |||
| let colName = groupColNames[colKey] | |||
| let colIndex = this.columnName.indexOf(colName) | |||
| let colDtype = this.colDtype[colIndex] | |||
| if (colDtype === "string") throw new Error(`Can't perform math operation on column ${colName}`) | |||
| let operationVal = (typeof operation === "string") ? operation : operation[colName] | |||
| if (colDtype === "string" && operationVal !== "count") throw new Error(`Can't perform math operation on column ${colName}`) | |||
There was a problem hiding this comment.
Yay! This will fix a problem I ran into.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #396
src/danfojs-browser/tests/aggregators/groupby.test.jssrc/danfojs-node/test/aggregators/groupby.test.tssrc/danfojs-base/aggregators/groupby.tsandsrc/danfojs-base/core/frame.tsto fix the issueFeel free to modify the code or add comments with the changes if you think something could be improved.
Thanks!