feat: Added pctChange() to DataFrame and divNoNan() to $MathOps in DataFrame
#418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff port into working branch for pct_change
Floating points are weird in JS. Will likely need refactor to make tests pass since _functionally_ they work.
NeonSpork
changed the title
NeonSpork
changed the title
pctChange() to DataFrame and divNoNan() to $MathOps in DataFrame
|
@risenW I can't quite seem to get the TensorFlow functions |
Wonkiness of slight difference in calculation (`0.80000000001234` instead of `0.8` for example) is due to JavaScript. Functionally the tests worked, so I chose divisions that JavaScript does reliably.
|
Worked around JavaScript's wonkiness in the tests by using divisions that perform more reliably. |
|
Added unit tests for |
|
@NeonSpork I just merged the diff PR, and there's a minor conflict here. Can you fix it, or do you want me to? |
Yea the merge conflicts are likely due to me adding the tests in the same spot in the test! I'll go through it and check right away |
|
Conflicts resolved and checks passed! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structure is similar to
diff()function, attempted to emulate the functionality frompct_change()function from pandas.Chose to use camelcase naming here, thusly naming it
pctChange().Added function to DataFrame interface.
Added
divNoNan()from the tensorflow.js math operators to$MathOps. This was necessary to emulate the functionality from pandas, such that dividing by zero resulted in 0 notInfinity. Felt that this was a good addition regardless, seeing as it is one of the baseline math operators provided by tensorflow.js itself. As such it was trivial to add. Tensorflow docs here: tf.divNoNan()Added testing. Tests technically work since they return the correct values, but the tests fail since JS is a little bit strange about floating point division.
A possible workaround is to choose calculations that will pass tests, since functionally
pctChange()is working as expected.