Attempt to simplify glue unit converter for PR 2022 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MNT: Deprecate CubeViz, MosViz, and SpecViz
This is caused by Voila 0.4.0 which is now based on ipywidgets 8. The Layout widget of v7 could not be created, resulting in the height of the plots not being set. See: spacetelescope#1787
…t_size fix: plots in popout window not scaled properly (by pinning voila<0.4)
Update glue, glue-jupyter minversion pins
for the two tests that keep getting socket timeout errors to convince ITSD that it is not us. Help desk ticket is INC0183598.
TST: Increase download_file timeout considerably
…telescope#1659) * fix for spacetelescope#1621: only concat x1d spectra from MIRI * More general solution based on FILENAME card * Bumping specutils installation requirement * Adding concat_by_file kwarg to trigger concat on load * Misunderstood my own comment, fixing spectrum list test * Removing specutils check for old version * Tweaking docstring in specviz_spectrum1d_parser * changing milestone * adding docstring, removing unused code * more helpful test comment * using defaultdict for spectra_to_combine * set random seed once for multi-order spectrum tests * doc: Adding brief advert for concat_by_file kwarg * Update CHANGES.rst Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
…etelescope#1825) * DOC: Clarify the role of centroid in aperture photometry plugin. BUG: Fix typo in doc ref. * DOC: Plots do use centroid
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
…mo_problems Disable 1D linking and Simultaneous Row Plotting in Mosviz
Cubeviz to support plain Numpy cube and GIF
…warnings large subset warnings in aperture photometry
* Fix case that used to break return_unique_name * return_unique_name should be the method to return a unique name * Increase max duplicate number by one if duplicate still exists * Updates changes file
Make get_interactive_regions snackbar message less alarming
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Avoid installation error by pinning y_py < 0.5.5
TST: Add RC testing workflow and update existing
* refactor mouseover coords info display * refactored to bring mouseover logic into the plugin itself * traitlets for information are now based on their position in the UI rather than their meaning for imviz (which was then "stretched" to apply to other viewers) * Apply suggestions from code review * clear world coords when appropriate on blink Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Update codeowners
* table subcomponent with popout support * table in aperture photometry plugin * rename add_row to add_item * and rename add_row to add_item * API docs for table subcomponent
* only disable auto-label if actually changing value instead of triggering on every keypress
[ci skip]
when loading valid data but axis not ready yet.
* First draft of refactor planning * Add new get_data method to ConfigHelper * Cover case where subsets_to_apply is None * Update comments and raise valueerror if valid data_label not provided * Address review comments * Remove unused imports * Fix f-string issue * Move if statement outside loop * Move cls code * Change cls to be None by default * Rearrange cls and subset_to_apply blocks * Fix docstrings * Add tests in imviz and specviz2d * Cover specviz2d specific line with test * Add more tests * Remove concept notebook * Remove changes to notebooks * Add check for statistic values * Remove percentile from statistic options * Remove percentile from docstring too * Fix bug with imviz data and Subset 1 not returning an NDData object * Fix code after last commit and add tests * Return spectrum1d obj in specviz2d with data of shape 2 * Only allow statistic to be set in cubeviz * Update changes file
…-col add aperture_sum_mag to aperture table cols
…ation Avoid JSON serialization warning
bump glue-astronomy to 0.6.1
Start changing unit conversion plugin Continue hacking
|
Wow, ok... I think maybe I rebased accidentally or something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at simplifying the unit converter proposed in spacetelescope#2022