-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assignment 5 - Redo Pull Request (headSimulatorTwo) #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not modify files in Modules that are not yours or shared
i.e., only include in your pull request your Module and Library Module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove your folder .idea from the commit
- Remove all class files (compiled files) from the commit
- For the files in the Library module put them in a package to avoid affecting the ones submitted by others. I will review an create a common Library later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Do not commit the target folder (class files).
- Maybe the README.md that you are uploading should be inside your Module otherwise explain the update
As of the latest commits, there is no 'target' folder (they've been deleted) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check. I still see them. I just deleted the README.md from your submission and a *.lck. But there are several others that should not be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clossing the request. Trying to add as many files as possible.
Note: - target files, idea folder, etc should not be included.
We have: