Skip to content

Commit

Permalink
Small MSVC configuration and code fixes when tried on totally empty f…
Browse files Browse the repository at this point in the history
…older to build the project
  • Loading branch information
ryobg committed Feb 6, 2018
1 parent 09ca264 commit 917f0f9
Show file tree
Hide file tree
Showing 9 changed files with 29 additions and 16 deletions.
7 changes: 6 additions & 1 deletion JContainers.sln
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "json_validator", "json_validator\json_validator.vcxproj", "{CAA7D417-1B58-48AB-A226-C7E69141772C}"
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "API_example", "api_usage_example\api_usage_example.vcxproj", "{6A52E028-EA40-467A-9055-6C7320B2746D}"
ProjectSection(ProjectDependencies) = postProject
{7028B79C-06E3-4D9A-B38C-1DC3680B1BDB} = {7028B79C-06E3-4D9A-B38C-1DC3680B1BDB}
EndProjectSection
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "post-build", "post-build\post-build.vcxproj", "{7A9BC6AF-C4C0-48EB-AE58-C64270A6823D}"
EndProject
Expand Down Expand Up @@ -52,7 +55,8 @@ Global
{C7305D8C-5514-4C58-9ED7-04D1D7A53D8D}.SKSE|x64.Build.0 = Release|x64
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Debug|Win32.ActiveCfg = Debug|Win32
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Debug|Win32.Build.0 = Debug|Win32
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Debug|x64.ActiveCfg = Debug|Win32
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Debug|x64.ActiveCfg = Debug|x64
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Debug|x64.Build.0 = Debug|x64
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Distrib|Win32.ActiveCfg = Release|Win32
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Distrib|Win32.Build.0 = Release|Win32
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Distrib|x64.ActiveCfg = Release|Win32
Expand All @@ -61,6 +65,7 @@ Global
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Release|Win32.ActiveCfg = Release|Win32
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Release|Win32.Build.0 = Release|Win32
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Release|x64.ActiveCfg = Release|x64
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.Release|x64.Build.0 = Release|x64
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.SKSE|Win32.ActiveCfg = Release|Win32
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.SKSE|Win32.Build.0 = Release|Win32
{20C6411C-596F-4B85-BE4E-8BC91F59D8A6}.SKSE|x64.ActiveCfg = Release|Win32
Expand Down
4 changes: 2 additions & 2 deletions JContainers/src/collections/tests.h
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ namespace collections { namespace {
for (auto id : identifiers) {
cntEx += (context.getObject(id) ? 1 : 0);
}
jc_debug("%u exist of %u", cntEx, identifiers.size());
jc_debug("%zu exist of %zu", cntEx, identifiers.size());
return cntEx == identifiers.size();
};

Expand All @@ -596,7 +596,7 @@ namespace collections { namespace {
for (auto id : identifiers) {
cntDestr += (context.getObject(id) ? 0 : 1);
}
jc_debug("%u destroyed of %u", cntDestr, identifiers.size());
jc_debug("%zu destroyed of %zu", cntDestr, identifiers.size());
return cntDestr == identifiers.size();
};

Expand Down
12 changes: 6 additions & 6 deletions api_usage_example/Source.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@

#include "jc_interface.h"

#include "skse/PluginAPI.h"
#include "skse/skse_version.h"
#include "skse/GameForms.h"
#include "skse/PapyrusNativeFunctions.h"
#include "skse/PapyrusForm.h"
#include "skse64/PluginAPI.h"
#include "skse64_common/skse_version.h"
#include "skse64/GameForms.h"
#include "skse64/PapyrusNativeFunctions.h"
#include "skse64/PapyrusForm.h"

class VMClassRegistry;

Expand Down Expand Up @@ -118,7 +118,7 @@ extern "C" {
_MESSAGE("loaded in editor, marking as incompatible");
return false;
}
else if (skse->runtimeVersion != RUNTIME_VERSION_1_9_32_0) {
else if (skse->runtimeVersion != RUNTIME_VERSION_1_5_23) {
_MESSAGE("unsupported runtime version %08X", skse->runtimeVersion);
return false;
}
Expand Down
7 changes: 5 additions & 2 deletions api_usage_example/api_usage_example.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,16 @@
<Optimization>Disabled</Optimization>
<SDLCheck>true</SDLCheck>
<AdditionalIncludeDirectories>$(SolutionDir)\dep\skse;$(SolutionDir)\dep;$(SolutionDir)\JContainers\src</AdditionalIncludeDirectories>
<PreprocessorDefinitions>%(PreprocessorDefinitions)</PreprocessorDefinitions>
<RuntimeLibrary>MultiThreaded</RuntimeLibrary>
<PreprocessorDefinitions>WIN32;_DEBUG;_WINDOWS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
<FunctionLevelLinking>true</FunctionLevelLinking>
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
</ClCompile>
<Link>
<GenerateDebugInformation>true</GenerateDebugInformation>
<AdditionalDependencies>kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies)</AdditionalDependencies>
<AdditionalLibraryDirectories>
</AdditionalLibraryDirectories>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
Expand Down
2 changes: 2 additions & 0 deletions dep/boost/build_libraries.bat
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
REM https://sourceforge.net/projects/boost/files/boost/1.66.0/

b2 variant=release link=static threading=multi runtime-link=static --with-serialization --with-date_time --with-filesystem --with-thread --build-dir=garbage --stagedir=boost_lib stage


Expand Down
2 changes: 1 addition & 1 deletion dep/common/common.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
<ClCompile>
<Optimization>Disabled</Optimization>
<AdditionalIncludeDirectories>$(SolutionDir);$(SolutionDir)\..;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>../;$(SolutionDir);$(SolutionDir)\..;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<PreprocessorDefinitions>WIN32;_DEBUG;_WINDOWS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<BasicRuntimeChecks>EnableFastChecks</BasicRuntimeChecks>
<RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
Expand Down
7 changes: 5 additions & 2 deletions dep/skse/skse64/skse64.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,19 @@
<WarningLevel>Level3</WarningLevel>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_DEBUG;_WINDOWS;_USRDLL;SKSE64_EXPORTS;RUNTIME_VERSION=0x01050170;RUNTIME;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalIncludeDirectories>$(SolutionDir);$(SolutionDir)\..;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>..\..\;..\;$(SolutionDir);$(SolutionDir)\..;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<ForcedIncludeFiles>common/IPrefix.h</ForcedIncludeFiles>
<RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
</ClCompile>
<Link>
<SubSystem>Windows</SubSystem>
<GenerateDebugInformation>true</GenerateDebugInformation>
<AdditionalDependencies>common.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies)</AdditionalDependencies>
<AdditionalLibraryDirectories>$(OutDir);%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
</Link>
<PostBuildEvent>
<Command>copy "$(TargetPath)" "$(Skyrim64Path)\$(TargetFileName)" /Y</Command>
<Command>
</Command>
</PostBuildEvent>
<PostBuildEvent>
<Message>Installing DLL...</Message>
Expand Down
2 changes: 1 addition & 1 deletion dep/skse/skse64_common/skse64_common.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
<WarningLevel>Level3</WarningLevel>
<Optimization>Disabled</Optimization>
<PreprocessorDefinitions>_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<AdditionalIncludeDirectories>$(SolutionDir);$(SolutionDir)\..;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<AdditionalIncludeDirectories>..\..\;..\;$(SolutionDir);$(SolutionDir)\..;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
<ForcedIncludeFiles>common/IPrefix.h</ForcedIncludeFiles>
<RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
</ClCompile>
Expand Down
2 changes: 1 addition & 1 deletion post-build/post-build.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
<OptimizeReferences>true</OptimizeReferences>
</Link>
<PreBuildEvent>
<Command>python.exe install_Local.py $(Configuration) "C:\\Games\\Nexus Mod Manager\\SkyrimSE\\JContainers-v3.3A\\JContainers-v3.3A"</Command>
<Command>python.exe install_Local.py $(Configuration) "C:\\Program Files\\Mod Organizer\\mods\\JContainers-v3.3A"</Command>
</PreBuildEvent>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Distrib|Win32'">
Expand Down

0 comments on commit 917f0f9

Please sign in to comment.