Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update playwright image version #7

Merged
merged 7 commits into from
May 17, 2024

Conversation

javierlopezdeancos
Copy link
Owner

@javierlopezdeancos javierlopezdeancos commented May 15, 2024

Update playwright container image version to v1.44.0

Description

Update playwright container image version to mcr.microsoft.com/playwright:v1.44.0-jammy
https://mcr.microsoft.com/en-us/product/playwright/tags

Note

Looking at the changelog v1.44.0 to the new version of
Playwright, there are some breaking changes in how
blob-reporter is generated.

This generation could have the next patterns

The report file name looks like report-<hash>.zip or report-<hash>-<shard_number>.zip 
when [sharding](https://playwright.dev/docs/test-sharding) is used.

Important

So is impossible to get the report file without changes in testcontainers-node library that allow
1 - read a container directory ❌
2 - get the report filename with hash ❌
3 - copy and extract this file to outside of container (this is implemented) ✅

So, and previously do that work we can continue using as report default name report.zip setting this value in the environment variable that allow override the report filename to blob reporters

PLAYWRIGHT_BLOB_OUTPUT_NAME="report.zip"

Caution

So we can do something like to fix the report filename without hash:

  const startedPlaywrightContainer = await new PlaywrightContainer(
      DEFAULT_PLAYWRIGHT_CONTAINER_IMAGE,
      EXTERNAL_PLAYWRIGHT_PROJECT_DIRECTORY,
    )
      .withEnvironment({ PLAYWRIGHT_BLOB_OUTPUT_NAME: "report.zip" })
      .start();

@javierlopezdeancos javierlopezdeancos merged commit 43e41a2 into main May 17, 2024
2 checks passed
@javierlopezdeancos javierlopezdeancos deleted the update-playwright-image-version branch May 17, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant