Skip to content

Commit

Permalink
fix(javite-webmvc): add local server URL before entry
Browse files Browse the repository at this point in the history
  • Loading branch information
benny123tw committed Jun 26, 2024
1 parent a9d61aa commit f13d45c
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ private void handleProdEnvironment(JspWriter out, ServletContext servletContext,

private void handleDevEnvironment(JspWriter out, String localServerUrl) throws IOException {
String viteClientScriptTag = HtmlUtils.generateScriptTag(localServerUrl + "/@vite/client");
String entryScriptTag = HtmlUtils.generateScriptTag(this.entry != null ? this.entry : "src/main.js");
String entryScriptTag = HtmlUtils.generateScriptTag(localServerUrl + "/" + entry);

out.print(viteClientScriptTag);
out.print(entryScriptTag);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,13 @@
import jakarta.servlet.jsp.JspWriter;
import jakarta.servlet.jsp.PageContext;
import jakarta.servlet.jsp.tagext.SimpleTagSupport;
import java.io.IOException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.lang.Nullable;
import org.springframework.web.context.WebApplicationContext;
import org.springframework.web.context.support.WebApplicationContextUtils;

import java.io.IOException;

/**
* Custom JSP tag to import Vite-generated assets.
* <p>
Expand Down Expand Up @@ -136,7 +135,7 @@ private void handleProdEnvironment(JspWriter out, ServletContext servletContext,

private void handleDevEnvironment(JspWriter out, String localServerUrl) throws IOException {
String viteClientScriptTag = HtmlUtils.generateScriptTag(localServerUrl + "/@vite/client");
String entryScriptTag = HtmlUtils.generateScriptTag(this.entry != null ? this.entry : "src/main.js");
String entryScriptTag = HtmlUtils.generateScriptTag(localServerUrl + "/" + entry);

out.print(viteClientScriptTag);
out.print(entryScriptTag);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package com.javite.spring.tags;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import static org.mockito.Mockito.contains;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

import com.javite.config.ViteProperties;
import com.javite.util.ManifestUtils;
import jakarta.servlet.ServletContext;
import jakarta.servlet.jsp.JspWriter;
import jakarta.servlet.jsp.PageContext;
Expand All @@ -15,8 +17,6 @@
import org.springframework.web.context.WebApplicationContext;
import org.springframework.web.context.support.WebApplicationContextUtils;

import static org.mockito.Mockito.*;

public class ViteImportTest {

@Mock
Expand Down Expand Up @@ -56,7 +56,7 @@ void testDoTagDebugMode() throws Exception {
viteImport.doTag();

verify(jspWriter).print("<script type=\"module\" src=\"http://localhost:5173/@vite/client\"></script>");
verify(jspWriter).print("<script type=\"module\" src=\"main.js\"></script>");
verify(jspWriter).print("<script type=\"module\" src=\"http://localhost:5173/main.js\"></script>");
}

@Test
Expand Down

0 comments on commit f13d45c

Please sign in to comment.