-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Efficiency improvements in cd/alphabet_languages #122
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 90.30% 90.35% +0.04%
==========================================
Files 11 11
Lines 1165 1171 +6
==========================================
+ Hits 1052 1058 +6
Misses 113 113
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a quick look over and there are some remarks. Make sure to run the bin/run_autofix.sh
to ensure that linters won't fail.
Regarding the "performance" effect/benefit I don't have the time to verify it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final thought on this.
Co-authored-by: TAHRI Ahmed R. <Ousret@users.noreply.github.com>
in order to keep naming style/conv from above
I brought some minor modifications to your fork. x0.1 faster. |
target_have_accents
&target_pure_latin
can be cached so the code is not run all the timeAnother idea: if you don't use character position in the most frequent characters per language in
assets/
the chars could be a set/frozenset instead of a list, that would make the line[c for c in language_characters if c in characters]
faster.