Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvement on CJK mess detection #43

Closed
wants to merge 3 commits into from

Conversation

Ousret
Copy link
Member

@Ousret Ousret commented May 23, 2021

Tests are in progress to validate this patch.
We encountered a small decrease in CJK confidence/mess detection in the 1.4 release. This PR aims to correct that.

The gain is minor.

@Ousret Ousret added the enhancement New feature or request label May 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2021

Codecov Report

Merging #43 (ce01b29) into master (84c4dae) will decrease coverage by 0.12%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   83.73%   83.61%   -0.13%     
==========================================
  Files          14       14              
  Lines         984      995      +11     
==========================================
+ Hits          824      832       +8     
- Misses        160      163       +3     
Impacted Files Coverage Δ
charset_normalizer/probe_chaos.py 79.77% <76.92%> (-0.47%) ⬇️
charset_normalizer/unicode.py 93.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c4dae...ce01b29. Read the comment docs.

@Ousret Ousret marked this pull request as draft May 28, 2021 05:08
@Ousret Ousret changed the title Minor improvement on CJK mess detection ~1% Minor improvement on CJK mess detection May 28, 2021
@Ousret
Copy link
Member Author

Ousret commented Jun 24, 2021

Closing in favor of #45

@Ousret Ousret closed this Jun 24, 2021
@Ousret Ousret deleted the patch-detect-improvement branch June 24, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants