Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Comply with isort, mypy, flake8 and black #81

Merged
merged 5 commits into from
Aug 12, 2021
Merged

🎨 Comply with isort, mypy, flake8 and black #81

merged 5 commits into from
Aug 12, 2021

Conversation

Ousret
Copy link
Member

@Ousret Ousret commented Aug 12, 2021

Long overdue PR. This should push further the CI quality pipeline.

@Ousret Ousret added the tests label Aug 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #81 (980d369) into master (d05e10c) will decrease coverage by 0.03%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   84.71%   84.68%   -0.04%     
==========================================
  Files          11       11              
  Lines        1145     1149       +4     
==========================================
+ Hits          970      973       +3     
- Misses        175      176       +1     
Impacted Files Coverage Δ
charset_normalizer/assets/__init__.py 100.00% <ø> (ø)
charset_normalizer/models.py 87.11% <62.06%> (ø)
charset_normalizer/cli/normalizer.py 64.83% <74.28%> (ø)
charset_normalizer/utils.py 77.40% <75.00%> (ø)
charset_normalizer/api.py 82.14% <84.00%> (+0.09%) ⬆️
charset_normalizer/legacy.py 86.66% <85.71%> (ø)
charset_normalizer/md.py 88.19% <95.83%> (ø)
charset_normalizer/cd.py 95.83% <96.77%> (-0.63%) ⬇️
charset_normalizer/__init__.py 100.00% <100.00%> (ø)
charset_normalizer/constant.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d05e10c...980d369. Read the comment docs.

@Ousret
Copy link
Member Author

Ousret commented Aug 12, 2021

will decrease coverage by 0.03%.

Can be dismissed...

@Ousret Ousret merged commit 14c74b4 into master Aug 12, 2021
@Ousret Ousret deleted the patch-lint branch August 12, 2021 21:50
Ousret added a commit that referenced this pull request Aug 19, 2021
@Ousret Ousret mentioned this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants