Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Adjust UnprintablePlugin to ignore "unprintable" spaces like IdeographicSpace #96

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

Ousret
Copy link
Member

@Ousret Ousret commented Sep 14, 2021

CJK/Ideographic spaces could mislead the mess detection. This fix that!

@Ousret Ousret added bug Something isn't working detection Related to the charset detection mechanism, chaos/mess/coherence labels Sep 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2021

Codecov Report

Merging #96 (64e077f) into master (ab17ac9) will not change coverage.
The diff coverage is n/a.

❗ Current head 64e077f differs from pull request most recent head ec92fa0. Consider uploading reports for the commit ec92fa0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files          11       11           
  Lines        1197     1197           
=======================================
  Hits         1024     1024           
  Misses        173      173           
Impacted Files Coverage Δ
charset_normalizer/md.py 87.86% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9bba4...ec92fa0. Read the comment docs.

@Ousret Ousret merged commit d62ac4c into master Sep 14, 2021
@Ousret Ousret deleted the patch-unprintable-md-plugin branch September 14, 2021 18:28
@Ousret Ousret mentioned this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working detection Related to the charset detection mechanism, chaos/mess/coherence
Development

Successfully merging this pull request may close these issues.

2 participants