Fix PRNGKeyArray.broadcast_to with scalar shape #10288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
requested changes
Apr 14, 2022
|
Should I add a test directly use PRNGKeyArray? Or just test with PRNGKey(will not use PRNGKeyArray unless config set custom prng key, while CI doesn't set this.) |
|
I would probably add the test somewhere near here: https://github.com/google/jax/blob/f8d796939212fd2b3651c10c5e00f2f7503453c2/tests/random_test.py#L1550-L1555 I don't think we test custom_prng on github CI, but we have other test coverage for that that will catch it (and eventually custom_prng will be on by default) |
jakevdp
reviewed
Apr 15, 2022
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.