Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typing] annotate lax.slicing #12697

Merged
merged 1 commit into from
Oct 10, 2022
Merged

[typing] annotate lax.slicing #12697

merged 1 commit into from
Oct 10, 2022

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Oct 7, 2022

Part of #12049

@jakevdp jakevdp self-assigned this Oct 7, 2022
@jakevdp jakevdp force-pushed the lax-slicing-types branch from 1dfabc5 to d20093a Compare October 7, 2022 15:56
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Oct 7, 2022
@jakevdp jakevdp force-pushed the lax-slicing-types branch from d20093a to 45d06e3 Compare October 7, 2022 16:18
@jakevdp jakevdp requested a review from sharadmv October 7, 2022 16:39
sharadmv
sharadmv requested changes Oct 7, 2022
View reviewed changes
jax/_src/lax/slicing.py Outdated Show resolved Hide resolved
jax/_src/lax/slicing.py Outdated Show resolved Hide resolved
@jakevdp jakevdp force-pushed the lax-slicing-types branch from 45d06e3 to ae9f8ee Compare October 9, 2022 11:21
@jakevdp jakevdp requested a review from sharadmv October 10, 2022 16:04
sharadmv
sharadmv approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@sharadmv sharadmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@copybara-service copybara-service bot merged commit 707b07c into jax-ml:main Oct 10, 2022
@jakevdp jakevdp deleted the lax-slicing-types branch October 10, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soraros soraros soraros left review comments

@sharadmv sharadmv sharadmv approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakevdp @sharadmv @soraros @kokoro-team