Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal jax.lax.asarray utility #15303

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Add internal jax.lax.asarray utility #15303

merged 1 commit into from
Mar 30, 2023

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Mar 29, 2023 •
edited
Loading

jnp.asarray is a huge API, and we don't always need its full power when converting ArrayLike to Array.

Putting this in lax makes sense to avoid circular imports when breaking up the lax_numpy.py monolith.

@jakevdp jakevdp self-assigned this Mar 29, 2023
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Mar 29, 2023
@jakevdp jakevdp force-pushed the lax-asarray branch 3 times, most recently from 4ec6a5a to 52fb796 Compare March 30, 2023 17:19
@jakevdp jakevdp requested a review from pschuh March 30, 2023 17:30
@soraros
Copy link

soraros commented Mar 30, 2023

I suppose this is the canonical asarray to use after check_arraylike in the future?

@jakevdp
Copy link
Collaborator Author

jakevdp commented Mar 30, 2023

I suppose this is the canonical asarray to use after check_arraylike in the future?

Yes, that's what I have in mind. We'll probably end up rolling the two together when addressing #14921

@copybara-service copybara-service bot mentioned this pull request Mar 30, 2023
Closed
copybara-service bot pushed a commit that referenced this pull request Mar 30, 2023
@pschuh
Format build files.
0316a42 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15303 from jakevdp:lax-asarray 8f72454
PiperOrigin-RevId: 520714080
copybara-service bot pushed a commit that referenced this pull request Mar 30, 2023
@pschuh
Format build files.
8c81f45 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15303 from jakevdp:lax-asarray 8f72454
PiperOrigin-RevId: 520714080
copybara-service bot pushed a commit that referenced this pull request Mar 30, 2023
@hawkinsp
Replace references to jax.interpreters with jax._src.interpreters in …
fd570e2 
…JAX core.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#15303 from jakevdp:lax-asarray 8f72454
PiperOrigin-RevId: 520635021
@copybara-service copybara-service bot mentioned this pull request Mar 30, 2023
Closed
@hawkinsp hawkinsp merged commit 23451dc into jax-ml:main Mar 30, 2023
@jakevdp jakevdp deleted the lax-asarray branch March 30, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pschuh pschuh pschuh approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakevdp @soraros @pschuh @hawkinsp @kokoro-team