[host_callback] Adjust the legacy compatibility mode for call_with_device #23789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_676720231
branch
from
be50ee6
to
8706631
Compare
…vice The jax.experimental.host_callback module is deprecated and will be removed. See #20385. The next step in the removal is to flip the flag `--jax_host_callback_legacy` to `False`, meaning that the host callback APIs will be implemented by way of `io_callback`. In this mode, the `call_with_device` and `tap_with_device` cannot be supported. We add a temporary mechanism to be used internally for a couple of projects that still use `call_with_device`: allow the use but force the device to be the first device. This mechanism is not used externally, and attempting to use `call_with_device` will continue to raise an error. PiperOrigin-RevId: 676720231
copybara-service
bot
force-pushed
the
test_676720231
branch
from
8706631
to
d750deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[host_callback] Adjust the legacy compatibility mode for call_with_device
The jax.experimental.host_callback module is deprecated and will be removed.
See #20385.
The next step in the removal is to flip the flag
--jax_host_callback_legacytoFalse, meaning that the host callback APIs will be implemented by way ofio_callback. In this mode, thecall_with_deviceandtap_with_devicecannot be supported.We add a temporary mechanism to be used internally for a couple of projects that still use
call_with_device: allow the use but force the device to be the first device. This mechanism is not used externally, and attempting to usecall_with_devicewill continue to raise an error.