Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better doc for jax.numpy.i0 #23790

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Better doc for jax.numpy.i0 #23790

merged 1 commit into from
Sep 20, 2024
+40 −6

Conversation

rajasekharporeddy
Copy link
Contributor

Part of #21461

jakevdp
jakevdp requested changes Sep 20, 2024
View reviewed changes
jax/_src/numpy/lax_numpy.py Show resolved Hide resolved
jax/_src/numpy/lax_numpy.py Outdated Show resolved Hide resolved
jax/_src/numpy/lax_numpy.py Show resolved Hide resolved
jax/_src/numpy/lax_numpy.py Outdated Show resolved Hide resolved
jax/_src/numpy/lax_numpy.py Show resolved Hide resolved
@rajasekharporeddy
Copy link
Contributor Author

Fixed the lint_and_typecheck error. Could you please trigger the tests again?

@jakevdp jakevdp self-assigned this Sep 20, 2024
jakevdp
jakevdp approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@jakevdp
Copy link
Collaborator

jakevdp commented Sep 20, 2024

Can you please squash the changes into a single commit?

@rajasekharporeddy
Copy link
Contributor Author

Thanks! Squashed into single commit.

@jakevdp jakevdp added pull ready Ready for copybara import and testing documentation labels Sep 20, 2024
@copybara-service copybara-service bot merged commit 419a0c4 into jax-ml:main Sep 20, 2024
10 checks passed
@rajasekharporeddy rajasekharporeddy deleted the testbranch3 branch September 20, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakevdp jakevdp jakevdp approved these changes

Assignees

@jakevdp jakevdp

Labels
documentation pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajasekharporeddy @jakevdp