don't generate lazy iota/eye/tri/delta with omnistaging #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjj
changed the title
hawkinsp
approved these changes
Oct 12, 2020
mattjj
force-pushed
the
lazy-simplification
branch
from
43be942 to
990dc57
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
…an internal test. PiperOrigin-RevId: 337216255
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
…an internal test. PiperOrigin-RevId: 337219426
mattjj
added a commit
that referenced
this pull request
Oct 22, 2020
mattjj
added a commit
that referenced
this pull request
Oct 22, 2020
mattjj
added a commit
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is disabling, but not removing the device constant part of #1668 when omnistaging is enabled. We can do this because after #3370 and #4038 omnistaging removes the need for lazy device constants in a jitted context. (They could still in principle be useful in an op-by-op context, but the power:weight isn't worthwhile anymore.)
After this change, with omnistaging enabled the only parts of the lazy sublanguage that are used are those to do with broadcasts and transposes.
#4536 is a follow-up that removes the lazy device constant stuff (rather than just disabling it when omnistaging is enabled).
fyi @jblespiau