Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize ravel_pytree to handle int types #6136

Merged
merged 1 commit into from
Mar 19, 2021
Merged

generalize ravel_pytree to handle int types #6136

merged 1 commit into from
Mar 19, 2021

Conversation

mattjj
Copy link
Collaborator

@mattjj mattjj commented Mar 19, 2021 •
edited
Loading

fixes #6135, fixes #1028. See also #190, #2056

@google-cla google-cla bot added the cla: yes label Mar 19, 2021
@mattjj mattjj requested a review from jakevdp March 19, 2021 17:22
jakevdp
jakevdp reviewed Mar 19, 2021
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a couple minor things.

jax/flatten_util.py Outdated Show resolved Hide resolved
tests/tree_util_test.py Outdated Show resolved Hide resolved
@mattjj mattjj force-pushed the ravel-pytree branch 2 times, most recently from 6c142c6 to d65bb62 Compare March 19, 2021 17:44
@mattjj mattjj marked this pull request as ready for review March 19, 2021 17:44
jakevdp
jakevdp approved these changes Mar 19, 2021
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mattjj mattjj added the pull ready Ready for copybara import and testing label Mar 19, 2021
@copybara-service copybara-service bot merged commit 36fba77 into master Mar 19, 2021
@mattjj mattjj deleted the ravel-pytree branch March 19, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakevdp jakevdp jakevdp approved these changes

Assignees
No one assigned
Labels
cla: yes pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unravel_pytree not functioning on integer input ravel_pytree does not work with int input
2 participants
@mattjj @jakevdp