Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scikit-learn rather than sklearn in docs/requirements.txt #7036

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

lesteve
Copy link
Contributor

@lesteve lesteve commented Jun 21, 2021

The sklearn package is an historical thing that should probably not be used by anyone see scikit-learn/scikit-learn#8215 (comment) for example for some caveats.

@google-cla
Copy link

google-cla bot commented Jun 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 21, 2021
@lesteve
Copy link
Contributor Author

lesteve commented Jun 21, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 21, 2021
@hawkinsp hawkinsp requested a review from jakevdp June 21, 2021 12:59
@lesteve
Copy link
Contributor Author

lesteve commented Jun 21, 2021

For completeness the failures in this PR (https://github.com/google/jax/pull/7036/checks?check_run_id=2875130113#step:8:304) are the same as in master (https://github.com/google/jax/runs/2875466140#step:8:304) and not related to this PR:

=========================== short test summary info ============================
FAILED tests/random_test.py::LaxRandomTest::testPoissonBatched - ValueError: ...
FAILED tests/random_test.py::LaxRandomTest::testPoisson_lam=0.5_dtype=int16
FAILED tests/random_test.py::LaxRandomTest::testPoisson_lam=0.5_dtype=int32
FAILED tests/random_test.py::LaxRandomTest::testPoisson_lam=3_dtype=int16 - V...
FAILED tests/random_test.py::LaxRandomTest::testPoisson_lam=3_dtype=int64 - V...
FAILED tests/random_test.py::LaxRandomTest::testPoisson_lam=500_dtype=int16
FAILED tests/random_test.py::LaxRandomTest::testPoisson_lam=500_dtype=int32
FAILED tests/random_test.py::LaxRandomTest::testPoisson_lam=50_dtype=int32 - ...
FAILED tests/random_test.py::LaxRandomTest::testPoisson_lam=9_dtype=int64 - V...

@jakevdp
Copy link
Collaborator

jakevdp commented Jun 21, 2021

Thanks for the PR - I'm working on fixing the CI issue right now (see #7039) then we can rebase and get this merged.

@jakevdp jakevdp self-assigned this Jun 21, 2021
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the change!

We'll get the CI sorted out and then get this merged.

@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Jun 21, 2021
@copybara-service copybara-service bot merged commit 3f768ee into jax-ml:main Jun 21, 2021
@lesteve lesteve deleted the patch-1 branch June 21, 2021 19:52
@lesteve
Copy link
Contributor Author

lesteve commented Jun 21, 2021

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants