-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scikit-learn rather than sklearn in docs/requirements.txt #7036
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
For completeness the failures in this PR (https://github.com/google/jax/pull/7036/checks?check_run_id=2875130113#step:8:304) are the same as in master (https://github.com/google/jax/runs/2875466140#step:8:304) and not related to this PR:
|
Thanks for the PR - I'm working on fixing the CI issue right now (see #7039) then we can rebase and get this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for the change!
We'll get the CI sorted out and then get this merged.
Great, thanks! |
The sklearn package is an historical thing that should probably not be used by anyone see scikit-learn/scikit-learn#8215 (comment) for example for some caveats.