Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support xz #108

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat: support xz #108

merged 1 commit into from
Nov 25, 2024

Conversation

t3hmrman
Copy link
Contributor

@t3hmrman t3hmrman commented Nov 25, 2024

This add support for .tar.xz files which are already supported by @actions/tool-cache upstream


Important

Adds support for .tar.xz files in GitHub Actions workflow and main script, updating extension handling and extraction logic.

  • Behavior:
    • Adds support for .tar.xz files in src/main.ts by updating SUPPORTED_TAR_EXTENSIONS and modifying regex in run().
    • Updates getExtractFn() to handle .tar.xz files.
  • Workflow:
    • Adds a new job weval in .github/workflows/test.yml to test .tar.xz file extraction.
    • Uses tar -xvf to extract .tar.xz files in the weval job.

This description was created by Ellipsis for 0a1650b. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0a1650b in 1 minute and 18 seconds

More details
  • Looked at 63 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/main.ts:346
  • Draft comment:
    Consider adding support for .tar.xz files in getExtractFlags by returning xJ for these files.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_Z8PjYsVD8E1OhnWh


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@t3hmrman t3hmrman force-pushed the feat=support-xz branch 13 times, most recently from dac0016 to 0843714 Compare November 25, 2024 15:50
Signed-off-by: vados <vados@vadosware.io>
@t3hmrman
Copy link
Contributor Author

Hey @jaxxstorm after a ton of testing this is finally ready for review 😅

Found some refactoring and subtle improvements to make -- hopefully the PR isn't too noisy.

@jaxxstorm
Copy link
Owner

Thanks for the awesome, PR! looks good

@jaxxstorm jaxxstorm merged commit cd6b2b7 into jaxxstorm:master Nov 25, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants