Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom extension matching #32

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

rvesse
Copy link
Contributor

@rvesse rvesse commented Oct 17, 2022

This commit adds support for customising extension matching. This can be used to install releases that are in alternative file formats, or lack a file extension entirely e.g. pure binaries.

When a download release asset is not an archive it is copied into the tool cache rather than being extracted to there. The copied asset may optionally be renamed and chmod'd if desired.

Also adds support for extracting release archives that are .tar.bz2 format (#26).

@rvesse rvesse marked this pull request as ready for review October 17, 2022 14:41
@rvesse rvesse force-pushed the custom-ext-matching branch 3 times, most recently from 0cf8596 to 1a07637 Compare October 17, 2022 14:52
@jaxxstorm
Copy link
Owner

@rvesse this looks great, would you mind rebasing and I'll merge?

@rvesse rvesse force-pushed the custom-ext-matching branch from 1a07637 to 5bed56d Compare December 9, 2022 09:41
@rvesse
Copy link
Contributor Author

rvesse commented Dec 9, 2022

@jaxxstorm No problem, should be rebased and ready to go now

@jaxxstorm
Copy link
Owner

@rvesse looks like the new tests failed

@rvesse rvesse force-pushed the custom-ext-matching branch from 5bed56d to 1a8c0dd Compare December 12, 2022 09:31
@rvesse
Copy link
Contributor Author

rvesse commented Dec 12, 2022

@rvesse looks like the new tests failed

Looks like I set the wrong arch value for the Mozilla grcov test, I think that's corrected now but because I changed the workflow file looks like you have to approve it running again

I did have to make a slight fix for extracting BZip2 archives which I have now pushed. Possible the grcov test might still fail on GitHub Actions as it seems to require the runner to have a specific version of glibc which I'm not sure will be true or not.

This commit adds support for customising extension matching.  This can
be used to install releases that are in alternative file formats, or
lack a file extension entirely e.g. pure binaries.

When a download release asset is not an archive it is copied into the
tool cache rather than being extracted to there.  The copied asset may
optionally be renamed and chmod'd if desired.

Also adds support for extracting release archives that are .tar.bz2
format.
@rvesse rvesse force-pushed the custom-ext-matching branch from 1a8c0dd to 6a7d694 Compare December 12, 2022 10:15
@jaxxstorm
Copy link
Owner

Thanks for the awesome contributions!

@jaxxstorm jaxxstorm merged commit 402ff66 into jaxxstorm:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants